[Bug 12886] New: shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Bug ID: 12886 Summary: shelfbrowser script should write headers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org The shelfbrowser script (opac/svc/shelfbrowser.pl) does not write http headers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31462&action=edit Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31462|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32351&action=edit Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure why this happens, but with the patch applied for every time I use the 'arrow' picture, a 1 appears in the bottom left corner. This doesn't happen without the patch applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32351|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33142&action=edit Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #3)
I am not sure why this happens, but with the patch applied for every time I use the 'arrow' picture, a 1 appears in the bottom left corner. This doesn't happen without the patch applied.
Silly error, print should have been removed, done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33142|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33178&action=edit [PASSED QA] Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header= <div id="shelfbrowser"> I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with "en" and translated templates) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org