[Bug 36899] New: Further improvements to holds request page, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Bug ID: 36899 Summary: Further improvements to holds request page, part 2 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Based on a comment in Bug 36854: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864#c10 The entire fieldset should be clickable, not just the radio button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166938&action=edit Bug 36899: Make entire fieldset clickable To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Follow the test plan from bug 36864 4. Now the entire disabled fieldset should be clickable. 5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864 [Bug 36864] Further improvements to holds request page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 [Bug 30579] When placing item level hold, some options that are not used are not disabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166939&action=edit Bug 36899: (follow-up) Prevent disabling when clicking twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166938|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 166944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166944&action=edit Bug 36899: Make entire fieldset clickable To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Follow the test plan from bug 36864 4. Now the entire disabled fieldset should be clickable. 5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166939|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 166945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166945&action=edit Bug 36899: (follow-up) Prevent disabling when clicking twice Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This is part of release notes| |improvements to placing | |holds from the record page | |in the staff interface. | |When selecting 'Hold next | |available item' or 'Hold a | |specific item' you can now | |select anywhere on that | |section of the page, | |instead of having to select | |the radio button beside | |each heading. CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Nice! This makes it so much nicer and easier to use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #6 from David Nind <david@davidnind.com> --- I've signed this off, but then discovered that this needs a follow-up for item groups ("Hold next available item from an item group"): - The fieldset heading has a border around it - You still need to click on the radio button/heading to select this option, rather than anywhere in this section of the page Enabling item groups and holds: 1. Enable the EnableItemGroups and EnableItemGroupHolds system preferences 2. Create item groups and add items to the groups: - find a record with multiple items - in the normal view > holdings table, select the 'Items group' tab - create two item groups (+ New item group) - from the holdings table, add items to the groups (select the tick box for an item, then options to 'Add/move to item group' and 'Remove from item group' appear) 3. Result: When placing a hold, there should be a new section "Hold next available item from an item group". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166946&action=edit Bug 36899: Account for item groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #6)
I've signed this off, but then discovered that this needs a follow-up for item groups ("Hold next available item from an item group"):
- The fieldset heading has a border around it - You still need to click on the radio button/heading to select this option, rather than anywhere in this section of the page
Enabling item groups and holds: 1. Enable the EnableItemGroups and EnableItemGroupHolds system preferences 2. Create item groups and add items to the groups: - find a record with multiple items - in the normal view > holdings table, select the 'Items group' tab - create two item groups (+ New item group) - from the holdings table, add items to the groups (select the tick box for an item, then options to 'Add/move to item group' and 'Remove from item group' appear) 3. Result: When placing a hold, there should be a new section "Hold next available item from an item group".
Thanks David! I have provided a follow-up for item groups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #8)
Thanks David! I have provided a follow-up for item groups.
Thanks Lucas! Can confirm that this all works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166944|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166971&action=edit Bug 36899: Make entire fieldset clickable To test: 1. APPLY PATCH 2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Follow the test plan from bug 36864 4. Now the entire disabled fieldset should be clickable. 5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166945|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166972&action=edit Bug 36899: (follow-up) Prevent disabling when clicking twice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166946|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166973&action=edit Bug 36899: Account for item groups Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This is part of |This is part of release notes|improvements to placing |improvements to placing |holds from the record page |holds from the record page |in the staff interface. |in the staff interface. |When selecting 'Hold next |When selecting 'Hold next |available item' or 'Hold a |available item', 'Hold next |specific item' you can now |available item from an item |select anywhere on that |group' (when item groups |section of the page, |enabled), or 'Hold a |instead of having to select |specific item' you can now |the radio button beside |select anywhere on that |each heading. |section of the page, | |instead of having to select | |the radio button beside | |each heading. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36864 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Bug 36899 depends on bug 30579, which changed state. Bug 30579 Summary: When placing item level hold, some options that are not used are not disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899 Bug 36899 depends on bug 30579, which changed state. Bug 30579 Summary: When placing item level hold, some options that are not used are not disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org