[Bug 12344] New: Multi transport types for issues and checkins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Bug ID: 12344 Summary: Multi transport types for issues and checkins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: benjamin.rokseth@kul.oslo.kommune.no QA Contact: testopia@bugs.koha-community.org This bug relates to bug #9016 - multi transport types already pushed to master (3.16). If a patron has enabled notice for checkin/checkout other than email, the message transport type (e.g. sms) is ignored in the notice generation. The affected method is C4::Circulation::SendCirculationAlert Generation of notice (C4::Letters::GetPreparedLetter) is done before the check for borrower's chosen transport types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 28605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28605&action=edit This small patch corrects the order of generating notices for issues and returns (checkout/checkin) so that borrower's notices are rendered correctly (for sms,email,etc.) Test plan: 1) Edit SMSSendDriver syspref to use driver 'Test' 2) Edit CHECKOUT template for sms to 'SMS test' 3) select SMS for test patron's messaging prefs for item checkout 4) checkout an item 5) check the table message_queue, verify that template sms is not used (message content is not 'SMS test') 6) apply patch, make new checkout 7) check that message_queue table now has a correctly generated notice with 'SMS test' For a real world test use a real SMS::Send driver and run the cronjob process-message-queue.pl to send messages immediately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28605|0 |1 is obsolete| | --- Comment #2 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 28606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28606&action=edit Bug 12344 - Multi transport types for issues and checkins This small patch corrects the order of generating notices for issues and returns (checkout/checkin) so that borrower's notices are rendered correctly (for sms,email,etc.) Test plan: 1) Edit SMSSendDriver syspref to use driver 'Test' 2) Edit CHECKOUT template for sms to 'SMS test' 3) select SMS for test patron's messaging prefs for item checkout 4) checkout an item 5) check the table message_queue, verify that template sms is not used (message content is not 'SMS test') 6) apply patch, make new checkout 7) check that message_queue table now has a correctly generated notice with 'SMS test' For a real world test use a real SMS::Send driver and run the cronjob process-message-queue.pl to send messages immediately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |benjamin.rokseth@kul.oslo.k |ity.org |ommune.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28606|0 |1 is obsolete| | --- Comment #3 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 36406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36406&action=edit Bug 12344 - Multi transport types for issues and checkins This small patch corrects the order of generating notices for issues and returns (checkout/checkin) so that borrower's notices are rendered correctly (for sms,email,etc.) Test plan: 1) Edit SMSSendDriver syspref to use driver 'Test' 2) Edit CHECKOUT template for sms to 'SMS test' 3) select SMS for test patron's messaging prefs for item checkout 4) checkout an item 5) check the table message_queue, verify that template sms is not used (message content is not 'SMS test') 6) apply patch, make new checkout 7) check that message_queue table now has a correctly generated notice with 'SMS test' For a real world test use a real SMS::Send driver and run the cronjob process-message-queue.pl to send messages immediately. http://bugs.koha-community.org/show_bug.cgi?id=12344 Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m Status|Needs Signoff |Signed Off --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Works as described : - without patch, letter model used is the one for email - with patch, letter model used is the one for sms -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I think I found an issue, to reproduce: Enable sms + email for checkout, check an item out => no letter is generated. Ok it's a configuration problem, but I think it could easily be fixed if you next instead of return if the template does not exist. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #6 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- good catch, Jonathan! If a patron enables multiple message types, and a message type is missing a template, it would return before processing the remaining types. A simple fix, as suggested, is to use next instead of return -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36406|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36568&action=edit Bug 12344 - Multi transport types for issues and checkins This small patch corrects the order of generating notices for issues and returns (checkout/checkin) so that borrower's notices are rendered correctly (for sms,email,etc.) Test plan: 1) Edit SMSSendDriver syspref to use driver 'Test' 2) Edit CHECKOUT template for sms to 'SMS test' 3) select SMS for test patron's messaging prefs for item checkout 4) checkout an item 5) check the table message_queue, verify that template sms is not used (message content is not 'SMS test') 6) apply patch, make new checkout 7) check that message_queue table now has a correctly generated notice with 'SMS test' For a real world test use a real SMS::Send driver and run the cronjob process-message-queue.pl to send messages immediately. http://bugs.koha-community.org/show_bug.cgi?id=12344 Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #8 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36570&action=edit QA followup: Use next instead of return when generating templates. In case patron has enabled a message type that misses a template, next message type will be attempted instead of returning at once. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36570|QA followup: |QA followup: skip message description| |type if template is missing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36568|0 |1 is obsolete| | Attachment #36570|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36576&action=edit Bug 12344 - Multi transport types for issues and checkins This small patch corrects the order of generating notices for issues and returns (checkout/checkin) so that borrower's notices are rendered correctly (for sms,email,etc.) Test plan: 1) Edit SMSSendDriver syspref to use driver 'Test' 2) Edit CHECKOUT template for sms to 'SMS test' 3) select SMS for test patron's messaging prefs for item checkout 4) checkout an item 5) check the table message_queue, verify that template sms is not used (message content is not 'SMS test') 6) apply patch, make new checkout 7) check that message_queue table now has a correctly generated notice with 'SMS test' For a real world test use a real SMS::Send driver and run the cronjob process-message-queue.pl to send messages immediately. Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36577&action=edit Bug 12344: QA followup: use next instead of return Use next instead of return when generating templates. In case patron has enabled a message type that misses a template, next message type will be attempted instead of returning at once. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Benjamin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 Just a note Benjamin, you might want to fix your git.author and git.email settings in your vagrant instance. Ive fixed the author in the 3.18.x branch, but its still wrong in master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #13 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Ah, I see. It was an old vagrant instance used on the first patch. How do you suggest I change? New patch and obsolete? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org