https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- NO_LIBRARY_SET is also used for the initial web install, which requires the DB user. So, probably not entirely removing NO_LIBRARY_SET, because the branches table won't even exist at the initial web install. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #2)

I can confirm it's fixed now - looks like we forgot to close the bug!

Sorry, wrong bug! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98934&action=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98936&action=edit Bug 21746: Remove GetLoggedInBranchcode This method from the Branches TT plugin is not needed as we can use logged_in_user -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Loggin into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Other occurrences will be check by QA that will make sure there is no typo in the patches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #9)

(In reply to Jonathan Druart from comment #8)

...

Test plan: * Confirm that the library's name is updated

This didn't work in my test. The previous library name still showed up.

Yes, sorry about that. I revived patches I had on a local branch, but they went to far and were wrong. Only the first patch is relevant here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99071|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99681&action=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No problem during install, nor changing library. Fixed (pre-existing) tab in circ/branchtransfers.pl No errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99681|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99833&action=edit Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No problem during install, nor changing library. Fixed (pre-existing) tab in circ/branchtransfers.pl No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin -- You are receiving this mail because: You are watching all bug changes.