[Bug 26761] New: Use aria-disabled attribute in OPAC cart for disabled links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Bug ID: 26761 Summary: Use aria-disabled attribute in OPAC cart for disabled links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 8712 There is no "disabled" property for the <a> tag, so we have to have a way in addition to color to express that a link is disabled. I think using the "aria-disabled" attribute would be helpful. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123344&action=edit Bug 26761: Use aria-disabled attribute in OPAC cart for disabled links This patch adds "aria-disabled" attributes to disabled links in the Cart, and adds JS to change the value from "true" to "false" when the links are enabled. The goal is to make the interface more informative to users of screen readers. To test, apply the patch and add some items to the Cart in the OPAC. - Inspect the markup of controls like "Remove", "Place hold," etc. Each should look disabled (grey) and has the correct aria-disabled attribute value. - Select one or more checkboxes. The links should be come active, and the aria-disabled attribute shoulk now be "false." - Deselect all checkboxes. The links should now be disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123344|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123348&action=edit Bug 26761: Use aria-disabled attribute in OPAC cart for disabled links This patch adds "aria-disabled" attributes to disabled links in the Cart, and adds JS to change the value from "true" to "false" when the links are enabled. The goal is to make the interface more informative to users of screen readers. To test, apply the patch and add some items to the Cart in the OPAC. - Inspect the markup of controls like "Remove", "Place hold," etc. Each should look disabled (grey) and has the correct aria-disabled attribute value. - Select one or more checkboxes. The links should be come active, and the aria-disabled attribute shoulk now be "false." - Deselect all checkboxes. The links should now be disabled. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | URL| |https://a11y-101.com/develo | |pment/aria-disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123348|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123718&action=edit Bug 26761: Use aria-disabled attribute in OPAC cart for disabled links This patch adds "aria-disabled" attributes to disabled links in the Cart, and adds JS to change the value from "true" to "false" when the links are enabled. The goal is to make the interface more informative to users of screen readers. To test, apply the patch and add some items to the Cart in the OPAC. - Inspect the markup of controls like "Remove", "Place hold," etc. Each should look disabled (grey) and has the correct aria-disabled attribute value. - Select one or more checkboxes. The links should be come active, and the aria-disabled attribute shoulk now be "false." - Deselect all checkboxes. The links should now be disabled. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org