[Bug 31566] New: 'Patrons selected' counter doubles on 'Select all'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug ID: 31566 Summary: 'Patrons selected' counter doubles on 'Select all' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 29971 The new 'Patrons selected' feedback introduced on bug 29971 doesn't work as expected with the 'Select all' feature.. if you click "Select all" once it counts as expected.. if you work with the checkboxes, the counter changes as expected.. if you change your mind and click 'Select all' again, the counter adds all results again, effectively doubling the count each time you click it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 [Bug 29971] Remember selections across patron search pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140923&action=edit Bug 31566: 'Patrons selected' counter doubles on 'Select all' This patch refines the JavaScript which is run when the "Select all" or "Clear all" controls are clicked. The script now checks to see whether the checkbox is checked before triggering the change function. To test, apply the patch and perform a patron search in the staff interface which will return multiple results. - After the patron search results are displayed, test the "Select all" control. The visible search results should all be checked, and the "Patrons selected" counter at the top should be incremented correctly. - Clicking the "Select all" control again should have no effect. The "Patrons selected" counter should not increment again. - Test the "Clear all" control to confirm that checkboxes are unchecked and the counter updates correctly. - Test with multiple pages of patron search results to confirm that the controls work correctly on any page of results.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140923|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 140959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140959&action=edit Bug 31566: 'Patrons selected' counter doubles on 'Select all' This patch refines the JavaScript which is run when the "Select all" or "Clear all" controls are clicked. The script now checks to see whether the checkbox is checked before triggering the change function. To test, apply the patch and perform a patron search in the staff interface which will return multiple results. - After the patron search results are displayed, test the "Select all" control. The visible search results should all be checked, and the "Patrons selected" counter at the top should be incremented correctly. - Clicking the "Select all" control again should have no effect. The "Patrons selected" counter should not increment again. - Test the "Clear all" control to confirm that checkboxes are unchecked and the counter updates correctly. - Test with multiple pages of patron search results to confirm that the controls work correctly on any page of results.. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 --- Comment #3 from David Nind <david@davidnind.com> --- Noted when testing: - The dropdown list for 'Show X entries' has the options: 10 20 (default) 20 50 100 All - Note that 20 is repeated. - This was there before the patch was applied, so not related to this bug and I should probably log as a separate one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140959|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141016&action=edit Bug 31566: 'Patrons selected' counter doubles on 'Select all' This patch refines the JavaScript which is run when the "Select all" or "Clear all" controls are clicked. The script now checks to see whether the checkbox is checked before triggering the change function. To test, apply the patch and perform a patron search in the staff interface which will return multiple results. - After the patron search results are displayed, test the "Select all" control. The visible search results should all be checked, and the "Patrons selected" counter at the top should be incremented correctly. - Clicking the "Select all" control again should have no effect. The "Patrons selected" counter should not increment again. - Test the "Clear all" control to confirm that checkboxes are unchecked and the counter updates correctly. - Test with multiple pages of patron search results to confirm that the controls work correctly on any page of results.. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug 31566 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug 31566 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug 31566 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org