[Bug 18283] New: Display improvements on report results - hide code and change wording
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Bug ID: 18283 Summary: Display improvements on report results - hide code and change wording Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61175&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works great. I would change it to a button and put it with the rest of the buttons at the top of the report. My 2 cents. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61175|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61192&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- I can not toggle code display. It seems that something went lost from previous patch: <a class="toggle_sql" id="toggle_sql_hid" href="#">Show sql code</a> <a class="toggle_sql" id="toggle_sql_vis" href="#" style="display:none;">Hide sql code</a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61192|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61207&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works great. Just need to add space between buttons. The picky part of me wants you to place the button between the New report and Edit buttons. Makes more sense to be there. But the space is a must. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61207|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61249&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61249|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 61253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61253&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61318&action=edit [SIGNED OFF] Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why is this supposed to be an improvement? What are the use cases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #10)
Why is this supposed to be an improvement? What are the use cases?
I can tell you that at our library, we have jquery setup that does something similar. It bugged me the moment we started using Koha that the SQL was showing. Your average staff person doesn't care about it, and depending on the size of your sql, you might have to scroll down a bit to see results. It's ugly. It makes sense to hide it, but be able to reveal it when needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #61253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61318|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61359&action=edit Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61360&action=edit Bug 18283: 'sql' should be 'SQL' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 [Bug 29312] Punctuation: Total number of results: 961 (300 shown) . -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org