[Bug 34289] New: UI issue on returns.pl when checking the forgive fines checkbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Bug ID: 34289 Summary: UI issue on returns.pl when checking the forgive fines checkbox Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 153509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153509&action=edit screenshot of the problem To recreate: 1. Turn on fines mode 2. Go to returns.pl (/cgi-bin/koha/circ/returns.pl) 3. Expand the the options so you see 'Forgive overdue charges'. 4. Check that box and check in an item 5. The item is checked in but now the input "Enter item barcode" is smaller than it should be and has a yellow background. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153570&action=edit Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153570|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 154103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154103&action=edit Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|UI issue on returns.pl when |UI issue on checkin page |checking the forgive fines |when checking the forgive |checkbox |fines checkbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154103|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154110&action=edit Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Since we have now : [% IF ( exemptfine ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" /> [% ELSIF ( dropboxmode ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" /> [% ELSE %] There is no difference between those two lines since type="text" is default behavior. Maybe merge into [% IF ( exemptfine || dropboxmode ) %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34572 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolin Somers from comment #5)
Maybe merge into [% IF ( exemptfine || dropboxmode ) %]
Bug 34572 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Frido this bug appears to have been pushed to 23.05.x but not yet updated on here on bugzilla. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Fridolin Somers from comment #5)
Maybe merge into [% IF ( exemptfine || dropboxmode ) %]
Bug 34572
Great :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Pedro Amorim from comment #7)
@Frido this bug appears to have been pushed to 23.05.x but not yet updated on here on bugzilla.
Oups indeed sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org