[Bug 9312] New: strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bug ID: 9312 Summary: strict perl for picture-upload.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com strict directive is commented for tools/picture-upload.pl. This is because many vars are missing explicit package name. I propose to correct only this bug, a complete work may be done like said in FIXME in head of file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14226&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14227&action=edit Proposed patch (follow-up 1) Perltidy on picture-upload.pl. (very prettier) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- git am -3 /tmp/Proposed-patch-follow-up-1-ZTkJrF.patch Applying: Bug 9312: strict perl for picture-upload.pl (followup 1) fatal: sha1 information is lacking or useless (tools/picture-upload.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9312: strict perl for picture-upload.pl (followup 1) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14226|0 |1 is obsolete| | --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14255&action=edit Proposed patch (rebased master) Patch rebased master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14227|0 |1 is obsolete| | --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14256&action=edit Proposed patch (follow-up 1) (rebased master) Patch rebased master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm not sure what's going on, but I still cannot apply the second patch. I still get the same 'sha1 information is lacking' error. (In reply to comment #5)
Created attachment 14256 [details] Proposed patch (follow-up 1) (rebased master)
Patch rebased master
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- "it works for me" % git reset --hard origin/master HEAD is now at 588a55a Merge branch 'bug_8984' into 3.12-master % git bz apply 9312 Bug 9312 - strict perl for picture-upload.pl Proposed patch (rebased master) Apply? [yn] y Applying: Bug 9312: strict perl for picture-upload.pl Proposed patch (follow-up 1) (rebased master) Apply? [yn] y Applying: Bug 9312: strict perl for picture-upload.pl (followup 1) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #6)
I'm not sure what's going on, but I still cannot apply the second patch. I still get the same 'sha1 information is lacking' error. Can you test with 'git apply' ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14623&action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14255|0 |1 is obsolete| | Attachment #14256|0 |1 is obsolete| | Attachment #14623|0 |1 is obsolete| | --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14624&action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14625&action=edit Bug 9312: whitespace cleanup for picture-upload.pl Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14626&action=edit Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Note that in the course of signing off I added a test plan, reworded a commit message, and added a followup patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches don't apply (conflicts with bug 9421). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14624|0 |1 is obsolete| | --- Comment #15 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18895&action=edit Bug 9312: strict perl for picture-upload.pl Patch rebased master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14625|0 |1 is obsolete| | --- Comment #16 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18896&action=edit Bug 9312: whitespace cleanup for picture-upload.pl Patch rewritten. No need to rebase, it is a code formatting using perltidy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14626|0 |1 is obsolete| | --- Comment #17 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18897&action=edit Bug 9312: fix a couple more uninitialized variable warnings Patch rebased master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- All patches rebased master. There are a lot of changes so I set to needs signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 18895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18895 Bug 9312: strict perl for picture-upload.pl Review of attachment 18895: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9312&attachment=18895) ----------------------------------------------------------------- ::: tools/picture-upload.pl @@ +19,5 @@
# #
+use strict; +use warnings;
'use Modern::Perl' is preferred for this nowadays. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18895|0 |1 is obsolete| | --- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18936&action=edit Bug 9312: strict perl for picture-upload.pl use of Modern::Perl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18896|0 |1 is obsolete| | --- Comment #21 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18937&action=edit Bug 9312: whitespace cleanup for picture-upload.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18897|0 |1 is obsolete| | --- Comment #22 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18938&action=edit Bug 9312: fix a couple more uninitialized variable warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #23 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- opendir RECDIR, $recursive_dir is much better written as opendir my $recdir, $recursive_dir That way no close is needed, it closes itself when goes out of scope (globs are passe :) If you choose to stick with globs, I'll sign it off as is. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #24 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Srdjan Jankovic from comment #23)
opendir RECDIR, $recursive_dir
is much better written as
opendir my $recdir, $recursive_dir
Ok, I thought is was not possible. Ok to use vars with those names. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 20548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20548&action=edit Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I got this error on uploading one image file: Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/testclone/tools/picture-upload.pl line 138 It seems that $results can be just 1. Line 138 refers to it as a hash: if ( %$results || %errors ) { And perl does not like that :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #27 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Newer versions of Perl shouldn't mind that. Older versions required, and up until 5.12 I believe preferred keys(%whatever). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #28 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- What is missing to pass QA ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #29 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolyn SOMERS from comment #28)
What is missing to pass QA ? Please see comment 26
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #30 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Comment 27 is misleading you cant use a string as a hash_ref in any release of perl. A variable called $results suggests theres a bit of confusion here. Meaningless variable names should be avoided, and we should be more explicit as to what we are testing. Another reason for failing QA is that a lexical dirhandle is replaced by the global DIR. That's surely a backward move -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #31 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Yes, sorry I misread the comment, I thought it was about if(%hash) vs if( keys %hash) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #32 from M. Tompsett <mtompset@hotmail.com> --- And now patch doesn't apply. Side comment: I personally don't like splitting the if condition on an assignment to the next line, because one may accidentally think you forgot a semi-colon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #32)
And now patch doesn't apply.
Fridolin, can you have a look please? fatal: sha1 information is lacking or useless (tools/picture-upload.pl).
Side comment: I personally don't like splitting the if condition on an assignment to the next line, because one may accidentally think you forgot a semi-colon.
The file has been formatted using perltidy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18936|0 |1 is obsolete| | --- Comment #34 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32753&action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18937|0 |1 is obsolete| | --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32754&action=edit Bug 9312: whitespace cleanup for picture-upload.pl Formatting code using perltidy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18938|0 |1 is obsolete| | --- Comment #36 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32755&action=edit Bug 9312: fix a couple more uninitialized variable warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20548|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32756&action=edit Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- It had conflicts, but no sha-1 errors this time. And the conflicts were obviously caused by perltidy'ing, so they were easy enough to fix up. I've attached the rebased versions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32753|0 |1 is obsolete| | --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32759&action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32754|0 |1 is obsolete| | --- Comment #40 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32760&action=edit Bug 9312: Perltidying picture-upload.pl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32755|0 |1 is obsolete| | --- Comment #41 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32761&action=edit Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32756|0 |1 is obsolete| | --- Comment #42 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32762&action=edit Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Sometimes our QA tools are pretty annoying, in cases like this, when its a tab in a comment, .. I don't think we really need to hold up a patch set for it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Uploding a single image from the tools area is broken with the patches: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/katrin/kohaclone/tools/picture-upload.pl line 136. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #44 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 32781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32781&action=edit Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN --------- 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32781|0 |1 is obsolete| | --- Comment #45 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 33355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33355&action=edit [SIGNED-OFF] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN --------- 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Image uploaded without problems No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com --- Comment #46 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- First 4 patches were signed, I tested all and signed the last one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33362&action=edit [PASSED QA] Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33363&action=edit [PASSED QA] Bug 9312: Perltidying picture-upload.pl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33364&action=edit [PASSED QA] Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33365&action=edit [PASSED QA] Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Sometimes our QA tools are pretty annoying, in cases like this, when its a tab in a comment, .. I don't think we really need to hold up a patch set for it Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33366&action=edit [PASSED QA] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN --------- 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Image uploaded without problems No koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org