[Bug 12101] New: Move Greybox library outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Bug ID: 12101 Summary: Move Greybox library outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The Greybox javascript library should be moved to intranet-tmpl/lib so that it doesn't have to be duplicated for each translation and so that the translation script won't have to parse it each time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27265&action=edit Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27265|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 27506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27506&action=edit Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27506|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27626&action=edit [PASSED QA] Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org