http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 02:25:28 UTC --- Created attachment 3489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3489 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-04 12:41:51 UTC --- casServersLoop template var depends on bug 5630, which still needs signoff. As I was the main developper of the CAS feature, someone else than me should signoff it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |Rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:22 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-15 02:18:27 UTC --- Does not apply Applying: Bug 5983 minor fix in html to improve translatability /home/chrisc/git/catalyst-koha/.git/rebase-apply/patch:14: trailing whitespace. <p><acronym title="Central Authentication Service">If you have a CAS account</acronym>, warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... <stdin>:14: trailing whitespace. <p><acronym title="Central Authentication Service">If you have a CAS account</acronym>, warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt Failed to merge in the changes. Patch failed at 0001 Bug 5983 minor fix in html to improve translatability I think this patch may no longer be needed. The existing code is <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, [% IF ( casServerUrl ) %] please <a href="[% casServerUrl %]">click here to login</a>.<p> [% END %] [% IF ( casServersLoop ) %] please choose against which one you would like to authenticate: </p> <ul> [% FOREACH casServer IN casServersLoop %] <li><a href="[% casServer.value %]">[% casServer.name %]</a></li> [% END %] [% END %] </ul> So I think this has been fixed already, if you agree please mark it so. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-17 06:39:13 UTC --- (In reply to comment #7)

I think a part of this patch is still relevant: -<p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, +<p><acronym title="Central Authentication Service">If you have a CAS account</acronym>,

Hmm but wouldn't that be wrong, the acronym tag should only be around the acronym shouldn't it? Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |kyle.m.hall@gmail.com Resolution|--- |WORKSFORME --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Looks like this was implemented by another patch at some point. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.