[Bug 32468] New: Vendors select only allows selecting from first 20 vendors by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Bug ID: 32468 Summary: Vendors select only allows selecting from first 20 vendors by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: martin.renvoize@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 32030 It looks like we forgot about API paging when implementing the vendors select box on ERM.. as such, by default, we can only access the first 20 vendors created on the system. Is there perhaps a Select2 style vue component we could lean on for this.. both to improve consistency and to resolve this paging issue too.? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We need that: https://select2.org/data-sources/ajax#pagination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are we using vue-select? I should look at the code, that component appears inspired by select2, with many similar options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144601&action=edit Bug 32468: ERM - Populate dropdown list with all entries The REST API routes is configured to return the 20 first results if _per_page is not provided. Here we want to display all the vendors/agreements/licenses/packages in the dropdown lists. Ideally we should implement an infinite scroll to not load all the data at once (https://vue-select.org/guide/infinite-scroll.html) Test plan: Create more than 20 vendors and confirm that, with this patch, all the vendors are display in the dropdown list displayed on the add agreement form Same for agreements, licenses and local packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144602&action=edit Bug 32468: Use fetchLocalTitleCount to know if local titles exist We don't need to fetch 20 titles to know if there is at least one. We should call fetchLocalTitleCount. Note that this should be implemented for all 'List' views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144603&action=edit Bug 32468: Remove unecessary fetch titles JS functions Those JS functions are no longer in use and can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 [Bug 32474] Implement infinite scroll in vue-select -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144601|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144620&action=edit Bug 32468: ERM - Populate dropdown list with all entries The REST API routes is configured to return the 20 first results if _per_page is not provided. Here we want to display all the vendors/agreements/licenses/packages in the dropdown lists. Ideally we should implement an infinite scroll to not load all the data at once (https://vue-select.org/guide/infinite-scroll.html) Test plan: Create more than 20 vendors and confirm that, with this patch, all the vendors are display in the dropdown list displayed on the add agreement form Same for agreements, licenses and local packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144602|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144621&action=edit Bug 32468: Use fetchLocalTitleCount to know if local titles exist We don't need to fetch 20 titles to know if there is at least one. We should call fetchLocalTitleCount. Note that this should be implemented for all 'List' views. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144603|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144622&action=edit Bug 32468: Remove unecessary fetch titles JS functions Those JS functions are no longer in use and can be removed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Just a couple notes to myself or anyone else testing ERM/vue stuff: -Apply patch -run yarn build_js -clear browser cache -test patch Like with SCSS toss out the compiled changes ( koha-tmpl/intranet-tmpl/prog/js/vue/dist/main.js ) and leave that to the RM/RMaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144620|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144714&action=edit Bug 32468: ERM - Populate dropdown list with all entries The REST API routes is configured to return the 20 first results if _per_page is not provided. Here we want to display all the vendors/agreements/licenses/packages in the dropdown lists. Ideally we should implement an infinite scroll to not load all the data at once (https://vue-select.org/guide/infinite-scroll.html) Test plan: Create more than 20 vendors and confirm that, with this patch, all the vendors are display in the dropdown list displayed on the add agreement form Same for agreements, licenses and local packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144621|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144715&action=edit Bug 32468: Use fetchLocalTitleCount to know if local titles exist We don't need to fetch 20 titles to know if there is at least one. We should call fetchLocalTitleCount. Note that this should be implemented for all 'List' views. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144622|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144716&action=edit Bug 32468: Remove unecessary fetch titles JS functions Those JS functions are no longer in use and can be removed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick fix Jonathan and the quick testing Lucas. All looks good and works for me.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32807 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 [Bug 36392] Only 20 vendors in ERM dropdown -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org