[Bug 25999] New: Renewal due date not being honoured for items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Bug ID: 25999 Summary: Renewal due date not being honoured for items with holds Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: hc@interleaf.ie QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 7088 added the ability to override renewals for items that have holds by adding the "AllowRenewalOnHoldOverride" syspref. When this sys. pref. is enabled and the "Override renewal restrictions" option is ticked on the checkouts table on a patron account and then an "on hold" item is selected in the renewal column the "On hold due date" box appears. This allows a renewal date to be applied to items with holds on them. For the most part, it works except in one scenario: A new date is selected in the "Renewal due date" box. This also populates the "On hold due date" box. The content in the "On hold due date" box is deleted. The selected items are renewed. The due date for the items with holds reverts to the parameters set for the patron category/item type combination in the fine and circulation rules. According to bug 7088 the item should be "renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box"" Has anyone else had this issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Depends on| |7088 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.11 |master --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Confirmed on master. Andrew, can you have a look please? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 [Bug 7088] Cannot renew items on hold even with override -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Only one value is passed to the renew script: + // Determine which due date we need to use + var dueDate = isOnReserve ? + $("#newonholdduedate input").val() : + $("#newduedate").val(); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Daphne Hoolahan <dch@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I have the feeling that AllowRenewalOnHoldOverride is never taken into account. Asked on IRC earlier today, but still waiting for an answer I need confirmation. On the checkouts table (circ/circulation.pl) we don't allow checkin if there are holds on the items. We did it because the code is terrible and we don't manage that properly from this view we now have "On hold" and the checkbox is not displayed there is still JS code related to this feature, but I think it should be removed hacking a bit the code I managed to get this input: https://snipboard.io/haileC.jpg "On hold due date" Can you confirm that we should never see it? (and that I can remove the related code) renew, not checkin AllowRenewalOnHoldOverride. what's that? the pref is off and I am seeing that: https://snipboard.io/1AprPK.jpg all this is crazy, or I am missing something my conclusion is that the pref is useless and the code related to "renew on hold" that is on the circ table can be removed please confirm.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
I have the feeling that AllowRenewalOnHoldOverride is never taken into
I tested on current master and the GUI still appears to work as expected, but the due data calculation is wrong: * Check out 39999000004571 to 42 * Renewal check box is visible * Place a hold on the record for Henry * Reload list of checkouts, check box is now replaced by "on hold" * Set AllowRenewalOnHoldOverride to enable * Reload list of checkouts page * Renewal checkbox is still locked/"on hold" * Check "Override renewal restrictions:" checkbox below table * Renewal checkbox appears * Check the checkbox - the hold due date input appears * Set a hold due date and renew - the date is not taken into account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I had this bug during training last week (on 24.05.05) and was able to recreate today on main. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org