[Bug 17615] New: LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Bug ID: 17615 Summary: LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: oliver.bock@aei.mpg.de QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org There's a regression in c74678a: when calling C4::Members::Attributes::UpdateBorrowerAttribute() the compiled attribute hash uses the member name "value" instead of "attribute". This causes silent data corruption as all updated borrower attributes are overwritten with NULL values. Best, Oliver -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 [Bug 15889] Login with LDAP deletes extended attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Assignee|gmcharlt@gmail.com |alex.arnaud@biblibre.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This one sounds very sensible, Alex please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It affects master as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #3 from Oliver Bock <oliver.bock@aei.mpg.de> --- Jonathan, as you just added #15889, please also take a look at #14625 and #16719 which have been sitting around for while now. There are a number of similar LDAP-Auth issues right now. Thanks guys, Oliver -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14625, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16719 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 57532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57532&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Test plan: - Update your configuration file to use LDAP authentication and enable update (<update>1</update>) option, - create a mapping on an existing extended attrbitutes in koha-conf file, - login with a user who has not this extended attribute set. The attribute of related LDAP entry should be set. - check that the user attribute has been created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Oliver Bock <oliver.bock@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57532|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|alex.arnaud@biblibre.com |oliver.bock@aei.mpg.de --- Comment #6 from Oliver Bock <oliver.bock@aei.mpg.de> --- Created attachment 57587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57587&action=edit sign-off patch Attaching the signed-off patch manually since "git bz" never worked for me (returns that I'm not logged in on "attach", despite "apply" works). FYI, I verified the actual patch but not the unit test. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Oliver Bock from comment #6)
Attaching the signed-off patch manually since "git bz" never worked for me (returns that I'm not logged in on "attach", despite "apply" works).
You must use the fishsoup branch (up-to-date) and correctly set your credential. See the wiki page for a step-by-step configuration. https://wiki.koha-community.org/wiki/Git_bz_configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Oliver Bock <oliver.bock@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57587|0 |1 is obsolete| | --- Comment #8 from Oliver Bock <oliver.bock@aei.mpg.de> --- Created attachment 57593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57593&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock <oliver.bock@aei.mpg.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #9 from Oliver Bock <oliver.bock@aei.mpg.de> --- (In reply to Jonathan Druart from comment #7)
You must use the fishsoup branch (up-to-date)
Ah, I missed that one a few months ago. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57593|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57619&action=edit [PASSED QA] Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock <oliver.bock@aei.mpg.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Cheers for the quick fix, works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Please rebase asap! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #13 from Oliver Bock <oliver.bock@aei.mpg.de> --- Hi guys, any update on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch currently doesn't apply, we are waiting for a rebase to the current code base. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #15 from Oliver Bock <oliver.bock@aei.mpg.de> --- That's what I meant by "this" :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Oliver Bock from comment #15)
That's what I meant by "this" :-)
This bug report is assignee to you, so we are waiting for you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #17 from Oliver Bock <oliver.bock@aei.mpg.de> --- Sorry, but I'm not the patch author. The author should rebase his patch, right? Cheers, Oliver -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Oliver Bock from comment #17)
Sorry, but I'm not the patch author. The author should rebase his patch, right?
Cheers, Oliver
Yep thats right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #19 from Oliver Bock <oliver.bock@aei.mpg.de> --- Ok, so just to confirm: you're not waiting for me but for Martin. Should the bug thus be assigned to him? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oliver.bock@aei.mpg.de |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57619|0 |1 is obsolete| | --- Comment #20 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59220&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock <oliver.bock@aei.mpg.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Was it a complex rebase? Maybe we can keep the sign-offs on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #22 from Oliver Bock <oliver.bock@aei.mpg.de> --- Yes, please. The actual change is a single word :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, 1 test fail for me: t/db_dependent/Auth_with_ldap.t .. 1/4 # Failed test 'Mapped attribute is BAR' # at t/db_dependent/Auth_with_ldap.t line 199. # got: undef # expected: 'BAR' # Looks like you failed 1 test of 9. # Failed test 'auth_by_bind = 1 tests' # at t/db_dependent/Auth_with_ldap.t line 243. # Looks like you failed 1 test of 4. # Failed test 'checkpw_ldap tests' # at t/db_dependent/Auth_with_ldap.t line 309. # Looks like you failed 1 test of 4. Does it pass for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #24 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #23)
Alex, 1 test fail for me:
t/db_dependent/Auth_with_ldap.t .. 1/4 # Failed test 'Mapped attribute is BAR' # at t/db_dependent/Auth_with_ldap.t line 199. # got: undef # expected: 'BAR' # Looks like you failed 1 test of 9.
# Failed test 'auth_by_bind = 1 tests' # at t/db_dependent/Auth_with_ldap.t line 243. # Looks like you failed 1 test of 4.
# Failed test 'checkpw_ldap tests' # at t/db_dependent/Auth_with_ldap.t line 309. # Looks like you failed 1 test of 4.
Does it pass for you?
Yes it passes successfully. Weird you got this, all seems to be mocked as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #25 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Alex Arnaud from comment #24)
(In reply to Jonathan Druart from comment #23)
Alex, 1 test fail for me:
t/db_dependent/Auth_with_ldap.t .. 1/4 # Failed test 'Mapped attribute is BAR' # at t/db_dependent/Auth_with_ldap.t line 199. # got: undef # expected: 'BAR' # Looks like you failed 1 test of 9.
# Failed test 'auth_by_bind = 1 tests' # at t/db_dependent/Auth_with_ldap.t line 243. # Looks like you failed 1 test of 4.
# Failed test 'checkpw_ldap tests' # at t/db_dependent/Auth_with_ldap.t line 309. # Looks like you failed 1 test of 4.
Does it pass for you?
Yes it passes successfully. Weird you got this, all seems to be mocked as expected.
Oops, using another database (the one provided by BZ 10337) it don't pass anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59220|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59263&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59263|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59264&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock <oliver.bock@aei.mpg.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #28 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59265&action=edit Bug 17615 - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59265|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59266&action=edit Bug 17615 - Fix unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I confirm that the tests now pass. If the patch was ok before the rebase, it must still be. Passing QA, trusting author and previous signoffs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I couldn't test this, trusting the tests, please don't disappoint! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #34 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #35 from Oliver Bock <oliver.bock@aei.mpg.de> --- IMHO, this can be closed. Thanks again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After releases we move older bugs from "RESOLVED FIXED" to "CLOSED FIXED" in a big bulk edit, but if you tested, it's ok to just do it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org