[Bug 28704] New: Library MARCOrgCode field needs maxlength attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Bug ID: 28704 Summary: Library MARCOrgCode field needs maxlength attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When adding or editing a library, the "MARC organization code" field should be limited to the maximum length defined in the table, which is 16. Otherwise the process will fail with an unhelpful message, "An error occurred when adding this library. The branchcode might already exist." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122800&action=edit Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122800|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123288&action=edit Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes an error that release notes| |occurs when you enter a | |"MARC organization code" in | |the form for adding and | |editing libraries. With | |this change the input field | |is limited to 16 | |characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123288|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123298&action=edit Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org