http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5986 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13486&action=edit Bug 6261 - Consolidate patron toolbar include files The staff client has two almost identical include files which can be consolidated: circ-toolbar.inc and members-toolbar.inc. This patch marges the slight differences between them and eliminates circ-toolbar.inc, that being the one which was used on fewer pages. In order to accommodate the different "destination" variable for operations which redirect back either to circ or patrons, circulation.pl defines "destination" in the template. To test, perform various operations from the toolbar on different patron-related pages. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #4 from Marc Véron <veron@veron.ch> --- Tested again with testplan from comment #2: a) Create a new patron b) Change registration date of patron (e.g. back one month) c) Go to More->Renew patron Without patch, I get a message like "a message like "Patron's account has been renewed until 18/02/2021" With patch, I get no message. Updated expiration date displays in "Library use" section I tested the scenario with circulation.pl (Checkout screen) and with moremember.pl (Detail screen) On the Detail screen it is OK for me to have no message, since the expiration date is displayed on this screen. On the Checkout screen, after renewing the screen switches to the Detail screen. This behaviour is for me OK as well and I suppose it behaves like this by design. ----- Question 1: What other scenarios should be tested? ----- Question 2: Bugzilla asks for patch cmplexity. Is ths a trivial or a small one? ----- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14203|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14235&action=edit [SIGNED-OFF] Bug 6261 [Revised] Consolidate patron toolbar include files The staff client has two almost identical include files which can be consolidated: circ-toolbar.inc and members-toolbar.inc. This patch marges the slight differences between them and eliminates circ-toolbar.inc, that being the one which was used on fewer pages. In order to accommodate the different "destination" variable for operations which redirect back either to circ or patrons, circulation.pl defines "destination" in the template. Revision corrects a redirect error in setstatus.pl which predates this patch but which never showed up until now. To test, perform various operations from the toolbar on at least two pages: circulation.pl and moremember.pl. Operations: Edit, add child, duplicate, change password, print (all options), search to hold, renew, set permissions, delete, update child to adult, and export checked-in barcodes. In most cases simply confirming that the link takes you to the right place is enough. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Looks good to me, no regression found. The patch merges 2 include template files into 1 (members-toolbar.inc), changes the permission for printing (from 'borrowers => 1' to 'circulate => circulate_remaining_permissions') and fixes a typo in the setstatus.pl script (bornum with borrowernumber). A future improvement could be done by managing the different files which use this include file specifying the destination variable (in order to be redirected to the page where the user was). Marked to Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14235|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14258&action=edit Bug 6261 [Revised] Consolidate patron toolbar include files The staff client has two almost identical include files which can be consolidated: circ-toolbar.inc and members-toolbar.inc. This patch marges the slight differences between them and eliminates circ-toolbar.inc, that being the one which was used on fewer pages. In order to accommodate the different "destination" variable for operations which redirect back either to circ or patrons, circulation.pl defines "destination" in the template. Revision corrects a redirect error in setstatus.pl which predates this patch but which never showed up until now. To test, perform various operations from the toolbar on at least two pages: circulation.pl and moremember.pl. Operations: Edit, add child, duplicate, change password, print (all options), search to hold, renew, set permissions, delete, update child to adult, and export checked-in barcodes. In most cases simply confirming that the link takes you to the right place is enough. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes@keep.pt --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 9279 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.