[Bug 33336] New: Use a dedicated column for plugin status in plugins table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Bug ID: 33336 Summary: Use a dedicated column for plugin status in plugins table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148697&action=edit Bug 33336: Use a dedicated column for plugin status in plugins table WIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148697|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148698&action=edit Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27188 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148698|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148765&action=edit Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148765|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149360&action=edit Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Matt Blenkinsop from comment #6)
Enhancement - not backporting to 22.11.x
Nice work everyone!
Hi, This is a really trivial patch, but the change is really useful for end users. Could you reconsider backporting ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Fridolin, I'm happy to backport this but we are currently in string freeze as we head towards this months release. We'll backport this at the start of next month once this release is finished -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Matt Blenkinsop from comment #8)
Hi Fridolin, I'm happy to backport this but we are currently in string freeze as we head towards this months release. We'll backport this at the start of next month once this release is finished
Great -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 22.11.x for 22.11.06 release. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00, 22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org