https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested the patches and they work as expected. Great job! Some remarks: Major: I'd say the ->merge method should execute code wrapped by a transaction. There are risky operations taking place in there. Minor: To my taste, I'd prefer ->merge to be a Koha::Patron method. i.e. no 'keeper' param, as you want to merge the patron list with $self. Also, I'm not sure about borrowernumbers, they could just be Koha::Patron objects passed, and simplify the logic in ->merge. Tests could be placed in t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.