[Bug 19338] New: Dates sorting incorrectly in opac-account.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Bug ID: 19338 Summary: Dates sorting incorrectly in opac-account.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: liz@catalyst.net.nz Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Looks like we never put the title-string spec in on this page to make the dates sort correctly. We should fix that, so that the dates are right in all formats. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 67195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67195&action=edit Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 67196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67196&action=edit Bug 19338 - followup - missing span Oops, missed a span. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- With patch applied dates do not sort at all. I think it is because of line 105 in opac-account.tt: <td><span title="[% account.date %]">[% ACCOUNT_LINE.date | $KohaDates %]</td> account.date should be: ACCOUNT_LINE.date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67195|0 |1 is obsolete| | Attachment #67196|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 67582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67582&action=edit Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67582|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67801&action=edit Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67801|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70154&action=edit Bug 19338 - Dates sorting incorrectly in opac-account.tt To test: Find an account with lots of fines/payments load up the borrower's account in the OPAC note that the sort on the dates sorts by day, and not by date. apply this patch reload the page, note that the sort on the dates is now correct. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org