[Bug 24323] New: Advanced editor - Invalid 008 with helper silently fails to save
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Bug ID: 24323 Summary: Advanced editor - Invalid 008 with helper silently fails to save Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: carnold@dgiinc.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 96702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96702&action=edit Record causing silent failure Steps to reproduce: 0/Save the attachment "errorrecord.mrc" 1/Login to Koha with "EnableAdvancedCatalogingEditor" set to "Enable" 2/Go to Cataloging->AdvancedEditor 3/Click "Import Record" and navigate to the record saved from step 0 3.5/Verify that the "helpers" are active (green boxes around the control fields) -> if not go to Settings and click "Show helpers for fixed and coded fields" 4/Add an 003 with "blah" as the text (required for the default cataloging config) 5/Hit "Save to catalog" Results: The button spins and then returns to normal but the record is not saved to the catalog and no error message is displayed. Expected results: Error reporting an invalid 008 field If you click back to "Show fields verbatim" red dots will appear in the invalid 008 fields. This record was retrieved from public Z39.50 servers for a project. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #1 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 96723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96723&action=edit Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |carnold@dgiinc.com |ity.org | --- Comment #2 from Cori Lynn Arnold <carnold@dgiinc.com> --- assigning to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #3 from Cori Lynn Arnold <carnold@dgiinc.com> --- *** Bug 24196 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #4 from Cori Lynn Arnold <carnold@dgiinc.com> --- *** Bug 24205 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96723|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96771&action=edit Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would be nice if the feedback would be more precise, highlighting the problem in the 008, but this is definitely a good step forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96771|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97166&action=edit Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97166|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97167&action=edit Bug 24323: Advanced editor - Display an error message if the record did not save Invalid 008 with helper silently fails to save. This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org