[Bug 25954] New: Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Bug ID: 25954 Summary: Header search forms should be labeled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The markup for the header search forms in the staff interface use a <p> tag to show descriptive text about the form. For instance: <p class="tip">Enter patron card number or partial name:</p> In most cases this can be replaced with a label: <label class="tip" for="findborrower">Enter patron card number or partial name:</label> This will improve accessibility and eliminate errors raised by WCAG checks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106659&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of <p class="tip"> with <label class="tip"> in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the <p> is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106659|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107896&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of <p class="tip"> with <label class="tip"> in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the <p> is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent work, all looks good to me.. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 107896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107896 Bug 25954: Replace paragraph tags with labels in header search forms Review of attachment 107896: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25954&attachment=107896) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc @@ +28,3 @@
<form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> + [% IF ( Koha.Preference('IntranetCatalogSearchPulldown') ) %] + <label class="tip" for="idx">Enter search keywords:</label>
I am not sure about for="idx", I think the label is still for "search-form" not for indices select... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107896|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 107900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107900&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of <p class="tip"> with <label class="tip"> in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the <p> is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #107900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Ignore my sign off, I tested this and it all looks good to me, I ran each page through a WCAG checker. I did not notice Josef's comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107896|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107915&action=edit Bug 25954: (Follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 107915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107915 Bug 25954: (Follow-up) Correct label "for" attribute Review of attachment 107915: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25954&attachment=107915) ----------------------------------------------------------------- Sorry being so pedantive... ::: koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc @@ +27,4 @@
<div id="catalog_search" class="residentsearch"> <form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> [% IF ( Koha.Preference('IntranetCatalogSearchPulldown') ) %] + <label class="tip" for="search-form">Enter search keywords:</label>
The label could be before IF and you do not need the ELSE branch then... also there are some more occurences, see: git grep 'for="idx"' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- So it need probably more refactoring... whole form with id "cat-search-block" could be in its own template? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #9)
So it need probably more refactoring...
This patch was what prompted me to start the conversation on koha-devel about consolidating the staff interface header search forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #10)
(In reply to Josef Moravec from comment #9)
So it need probably more refactoring...
This patch was what prompted me to start the conversation on koha-devel about consolidating the staff interface header search forms.
I still like the idea - because it means we have less files to change something when needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #10)
(In reply to Josef Moravec from comment #9)
So it need probably more refactoring...
This patch was what prompted me to start the conversation on koha-devel about consolidating the staff interface header search forms.
I see, sorry I missed the whole conversation on koha-devel So, I think we could go with this patches and refactoring on another bug report? Looks like, there is no clear consensus on that conversation. I do not have strong opinion on that other that it needs to be refactored somehow... But I could imagine one big file, or WRAPPER (as mantioned by Julian) approach... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107915|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107986&action=edit Bug 25954: (Follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With the patch applied some of the labels jump in front of the search field while others remain above, an example would be the administration module. I did run yarn build and restart_all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #14)
With the patch applied some of the labels jump in front of the search field while others remain above
Could you look at this again? The problem you describe would happen if the CSS hasn't been regenerated. I know you said you did, but I'm hoping it was a glitch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107896|0 |1 is obsolete| | Attachment #107986|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 113747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113747&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of <p class="tip"> with <label class="tip"> in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the <p> is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 113748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113748&action=edit Bug 25954: (follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 113749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113749&action=edit Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search Change it from first select box to text input for consistancy with other search forms Test plan: 1) Apply the patch 2) Go to authorities search 3) Confirm the labels in all search tabs are linked to text input field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- I would consider it PQA, but would like to somebody to look into my follow-up to ensure it does make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113747|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114681&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of <p class="tip"> with <label class="tip"> in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the <p> is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113748|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114682&action=edit Bug 25954: (follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113749|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114683&action=edit Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search Change it from first select box to text input for consistancy with other search forms Test plan: 1) Apply the patch 2) Go to authorities search 3) Confirm the labels in all search tabs are linked to text input field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, the following changes is causing t/db_dependent/selenium/administration_tasks.t to fail: diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc index a77b92c6d5..8640c2268e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc @@ -3,18 +3,22 @@ <h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName | html %]</a></h1><!-- Begin Patrons Admin Resident Search Box --> <div id="header_search"> <div id="patron_category_search" class="residentsearch"> - <p class="tip">Search by patron category name:</p> <form action="[% script_name | html %]" method="post"> - <input class="head-searchbox" type="text" name="description" size="40" value="[% searchfield | html %]" /> + <label class="tip" for="description">Search by patron category name:</label> + <input class="head-searchbox" type="text" name="description" id="description" size="40" value="[% searchfield | html %]" /> There are now 2 elements with id="description" in the DOM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The following patch would make the tests pass again. - <input class="head-searchbox" type="text" name="description" id="description" size="40" value="[% searchfield | html %]" /> + <input class="head-searchbox" type="text" name="description" size="40" value="[% searchfield | html %]" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114790&action=edit Bug 25954: Prevent two elements with id="description" in the DOM It also fixes t/db_dependent/selenium/administration_tasks.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #26)
Created attachment 114790 [details] [review] Bug 25954: Prevent two elements with id="description" in the DOM
It also fixes t/db_dependent/selenium/administration_tasks.t
Pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Note that there is no change in appearance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.08.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 [Bug 27703] Can't navigate in Authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 [Bug 27713] Duplicate search field IDs in MARC framework administration template -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org