[Bug 20238] New: Show description of ITEMTYPECAT instead of code in itemtypes summary table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Bug ID: 20238 Summary: Show description of ITEMTYPECAT instead of code in itemtypes summary table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When working with grouped item types using ITEMTYPECAT authorised values, looking at the item types table, it shows the code, not the description. On editing an item type, we show the description - so there is some confusing mismatch there. Both should show the description. To check: - Add a value to the ITEMTYPECAT authorised value category - Edit an item type and pick that value as search category - Save - Verify the code shows up in the table, but not the description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can probably be fixed using a TT plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #2 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84112&action=edit Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table Test plan: 1. From homepage, go to Koha Amdinistration 2. Go to Authorised Values 3. Scroll down to ITEMTYPECAT and click Add 4. Give the new authorised value an Authorised value and Description 5. Save it 6. On the left, go to Item types 7. Click Edit on an item type 8. Under Search Catergory, select the new authorised value you just created. It should appear in the dropdown as it's description 9. Click Save changes 10. Under Search category for the item type you just edited, you should see your new authorised values' description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |ethan.amohia@gmail.com CC| |ethan.amohia@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This patch works well, but I think Katrin's suggestion is the more efficient solution. There's a shortcut for getting the description of authorised values. The template already has [% USE AuthorisedValues %] included, so we know the plugin is already being loaded for use: [% AuthorisedValues.GetByCode( 'ITEMTYPECAT', itemtype.searchcategory ) | html %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84112|0 |1 is obsolete| | --- Comment #4 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84158&action=edit Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table Test plan: 1. From homepage, go to Koha Amdinistration 2. Go to Authorised Values 3. Scroll down to ITEMTYPECAT and click Add 4. Give the new authorised value an Authorised value and Description 5. Save it 6. On the left, go to Item types 7. Click Edit on an item type 8. Under Search Catergory, select the new authorised value you just created. It should appear in the dropdown as it's description 9. Click Save changes 10. Under Search category for the item type you just edited, you should see your new authorised values' description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84158|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 84226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84226&action=edit Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table Test plan: 1. From homepage, go to Koha Amdinistration 2. Go to Authorised Values 3. Scroll down to ITEMTYPECAT and click Add 4. Give the new authorised value an Authorised value and Description 5. Save it 6. On the left, go to Item types 7. Click Edit on an item type 8. Under Search Catergory, select the new authorised value you just created. It should appear in the dropdown as it's description 9. Click Save changes 10. Under Search category for the item type you just edited, you should see your new authorised values' description Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but there are some things wrong with this patch: 1) If you take a look at the changes commited, you can see it includs a lot of unintentional changes: --- Koha/Illbackends/BLDSS | 1 + Koha/Illbackends/koha-ill-freeform | 1 + admin/itemtypes.pl | 2 ++ koha-ill-freeform | 1 + .../prog/en/modules/admin/.itemtypes.tt.swp | Bin 0 -> 40960 bytes .../intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 4 +++- 6 files changed, 8 insertions(+), 1 deletion(-) create mode 160000 Koha/Illbackends/BLDSS create mode 160000 Koha/Illbackends/koha-ill-freeform create mode 160000 koha-ill-freeform create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/.itemtypes.tt.swp 2) Using the TT plugin on the template side, the changes to admin/itemtypes.pl are no longer needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This would be a nice one to save! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amyking386@gmail.com Assignee|ethan.amohia@gmail.com |amyking386@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #8 from Amy King <amyking386@gmail.com> --- Created attachment 115497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115497&action=edit Bug 20238: Descrip of ITEMTYPECAT now shows on itemtypes summary table Test plan: 1. From homepage, go to Koha Administration 2. Go to Authorised Values 3. Scroll to the bottom of the page and click next 4. Find ITEMTYPECAT and click Add 5. Give the new authorised value an Authorised value and Description 6. Save it 7. On the left, got to Item types 8. Click Edit on an item type 9. Under Search Category, select the new authorised value you just created. It should appear in the dropdown as it's description 10. Click save changes 11. Under search category for the item type you just edited, you should see your new authorised values' description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #84226|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Comment on attachment 84226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84226 Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table I think this patch (the original one) is no longer required, so have obsoleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84226|1 |0 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Comment on attachment 84226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84226 Bug 20238: Description of ITEMTYPECAT now shows on itemtypes summary table I think I made a mistake, so unobsoleting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from David Nind <david@davidnind.com> --- Hi Amy. There are two patches for this bug, when I think there should only be one. If I apply all the patches the patches don't apply. If I just apply your patch it still requires something additional I think to solve the issue - displaying the authorized value description in the the item types search category column. Slightly updated bug commit message with description of what the bug does: Bug 20238: Display description of ITEMTYPECAT on item types summary table When adding or editing item types (Administration > Basic parameters
Item types) the drop down list currently displays the ITEMTYPECAT authorized value description and on the list of item types page the authorized value is displayed in the search category column.
This enhancement changes the item types list so that the search category column displays the authorized value's description instead of the authorized value. Test plan: 1. From homepage, go to Koha Administration 2. Go to Authorized values 3. Scroll to the bottom of the page and click next 4. Find ITEMTYPECAT and click Add 5. Give the new authorized value an Authorised value and Description 6. Save it 7. On the left, got to Item types 8. Click Edit on an item type 9. Under Search category, select the new authorized value you just created. It should appear in the dropdown as its description 10. Click save changes 11. Under search category for the item type you just edited, you should see your new authorized values' description Unless I've misunderstood things, then please ignore me! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #12 from Amy King <amyking386@gmail.com> --- Created attachment 115633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115633&action=edit Bug 20238: Display description of ITEMTYPECAT in search category Test plan: 1. From homepage, go to Koha Administration 2. Go to Authorized values 3. Scroll to the bottom of page, or click next at the top, to go to the next page 4. Find ITEMTYPECAT and click Add 5. Give the new authorized value an Authorized value and Description 6. Save it 7. On the left, go to Item types 8. Click Edit on an item type 9. Under search category, select the new authorized value you just created. It should appear in the dropdown as its description 10. Click save changes 11. Under search category for the item type you just edited, you should see your new Authorized values' description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115497|0 |1 is obsolete| | Attachment #115633|0 |1 is obsolete| | --- Comment #13 from Amy King <amyking386@gmail.com> --- Created attachment 115634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115634&action=edit Bug 20238: Display description of ITEMTYPECAT in search category Test plan: 1. From homepage, go to Koha Administration 2. Go to Authorized values 3. Scroll to the bottom of page, or click next at the top, to go to the next page 4. Find ITEMTYPECAT and click Add 5. Give the new authorized value an Authorized value and Description 6. Save it 7. On the left, go to Item types 8. Click Edit on an item type 9. Under search category, select the new authorized value you just created. It should appear in the dropdown as its description 10. Click save changes 11. Under search category for the item type you just edited, you should see your new Authorized values' description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115634|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 115716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115716&action=edit Bug 20238: Display description of ITEMTYPECAT in search category When adding or editing item types (Koha administration > Basic parameters > Item types) the drop down list currently displays the ITEMTYPECAT authorized value description. However, on the item types page the authorized value is displayed in the search category column. This enhancement changes the item types page so that the search category column displays the authorized value's description instead of the authorized value code. Test plan: 1. Go to Staff interface home page > Koha administration > Basic parameters > Authorized values. 2. Find ITEMTYPECAT and add a new authorized value - make sure it has a description. 3. Go to the Basic parameters > Item types page. 4. Edit an item type. 5. For the search category, select the new authorized value you created. The desciption should be shown in the dropdown list. 6. Save the changes. 7. In the search category column for the item type you edited, it should now display the description instead of the code. 8. Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the item types page (Koha | |administration > Basic | |parameters > Item types) so | |that the search category | |column displays the | |ITEMTYPECAT authorized | |value's description, | |instead of the authorized | |value code. (This makes it | |consistent with the edit | |form where it displays the | |descriptions for authorized | |values.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #15 from David Nind <david@davidnind.com> --- Thanks Amy! I'm not sure why your patch didn't work for me when I originally tested it, but it does now! I updated the commit message and also added suggested text for the release notes. Question for QA - If there is no description text for an authorised value, should there be a fallback to displaying the category, rather than displaying nothing? Or is this the default behaviour? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115716|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115913&action=edit Bug 20238: Display description of ITEMTYPECAT in search category When adding or editing item types (Koha administration > Basic parameters > Item types) the drop down list currently displays the ITEMTYPECAT authorized value description. However, on the item types page the authorized value is displayed in the search category column. This enhancement changes the item types page so that the search category column displays the authorized value's description instead of the authorized value code. Test plan: 1. Go to Staff interface home page > Koha administration > Basic parameters > Authorized values. 2. Find ITEMTYPECAT and add a new authorized value - make sure it has a description. 3. Go to the Basic parameters > Item types page. 4. Edit an item type. 5. For the search category, select the new authorized value you created. The desciption should be shown in the dropdown list. 6. Save the changes. 7. In the search category column for the item type you edited, it should now display the description instead of the code. 8. Sign off! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew@bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org