[Bug 26282] New: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Bug ID: 26282 Summary: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 25534 Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109286&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
2) Visit each area in Koha where a hold can be canceled with a reason
3 places according to the patch code. A. pendingreserves B. Record page => Holds (it's the list of holds bellow the patron search field) C. Same template but I don't get where this code is displayed Missing place found: in the patron's page. Hint for other places: due to clubs, are there other places to cancel holds? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Considering this one a bug fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, this is blocker for the release. Can you have another try please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113960&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Potential issue found: "No reason given" => no notification sent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113991&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #7)
Created attachment 113991 [details] [review] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want that. I'd prefer to adjust the label of the checkbox instead (or better, disable the checkbox if no option is selected). What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Kyle M Hall from comment #7)
Created attachment 113991 [details] [review] [review] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want that. I'd prefer to adjust the label of the checkbox instead (or better, disable the checkbox if no option is selected). What do you think?
That is how it functioned previously. I'm not sure what you mean by adjusting the label of the checkbox. A reason with a value of "" or "0" is certainly valid in Koha, so we shouldn't prevent sending a notice just because that's how the library has set up the AV values. The default AV values support this, since one of them is already failing to send a notice. IMO it makes for extra unnecessary steps to require a librarian to both select a reason *and* check the checkbox. When the library could have their 'default' reason be the first reason. It feels like design over usability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Kyle M Hall from comment #7)
Created attachment 113991 [details] [review] [review] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want that. I'd prefer to adjust the label of the checkbox instead (or better, disable the checkbox if no option is selected). What do you think?
I think both (having a cancellation reason and choosing to notify) should be independent. I'm not sure why setting a reason should put a constraint on notifying the patron the hold has been cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #9)
(In reply to Jonathan Druart from comment #8)
(In reply to Kyle M Hall from comment #7)
Created attachment 113991 [details] [review] [review] [review] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want that. I'd prefer to adjust the label of the checkbox instead (or better, disable the checkbox if no option is selected). What do you think?
That is how it functioned previously. I'm not sure what you mean by adjusting the label of the checkbox.
Previously what? On master there is: if ( $params->{cancellation_reason} ) { then send the notice So if no reason is chosen, no notice is sent. In my understanding, the limit of this bug report is to add the checkbox, not to change this behaviour. My suggestion was to modify the label "Notify patron" with something like "Notify patron if a reason is selected". It's not optimal, and that's why I suggested to disable the checkbox until an option was selected from the "reason" dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #11)
(In reply to Kyle M Hall from comment #9)
(In reply to Jonathan Druart from comment #8)
(In reply to Kyle M Hall from comment #7)
Created attachment 113991 [details] [review] [review] [review] [review] Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked
I am not sure we want that. I'd prefer to adjust the label of the checkbox instead (or better, disable the checkbox if no option is selected). What do you think?
That is how it functioned previously. I'm not sure what you mean by adjusting the label of the checkbox.
Previously what?
On master there is: if ( $params->{cancellation_reason} ) { then send the notice
So if no reason is chosen, no notice is sent.
In my understanding, the limit of this bug report is to add the checkbox, not to change this behaviour.
My suggestion was to modify the label "Notify patron" with something like "Notify patron if a reason is selected". It's not optimal, and that's why I suggested to disable the checkbox until an option was selected from the "reason" dropdown list.
I do agree with you Jonathan - this is change in behaviour, and disabling checkbox when no reason is selected is definitely solution for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12656 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This will also need some handling added to misc/cronjobs/holds/cancel_expired_holds.pl to re-enable the option to send notices when holds are automatically cancelled on expiration as per bug 12656 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109286|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114007&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113960|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114008&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113991|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114009&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114010&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As this is an entirely new notice this cycle, I'd be tempted to update the default to check for the presence of 'reason' and give a slightly different form if it is not present.... as a side note, if we're going to allow notifications without a reason, then perhaps rather than a checkbox we should instead have 'Confirm', 'Confirm and notify` and `Cancel` buttons/links to close the modal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We are D-1 before the release, I'd like a patch as small as possible. And I won't have time to test it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114011&action=edit Bug 26282: Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114012&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114013&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114014&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114015&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114016&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The letter is: """ Your hold for De Crasi Aristophea was canceled for the following reason: """ if you don't select a reason... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So, to resume a private discussion. We are trying to modify a behaviour that is not advertise in comment 0, neither on bug 25534 and so it's not the point of this bug report. I still don't understand Kyle's "That is how it functioned previously". My suggestion is still the same as comment 8, we remove the last 3 patches, adjust the checkbox's label with "only if a reason is selected". However the best would be to disable the checkbox until an option is selected, to not introduce new strings (release planned tomorrow...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114014|0 |1 is obsolete| | Attachment #114015|0 |1 is obsolete| | Attachment #114016|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114028&action=edit Bug 26282: Disable the checkbox if no reason selected On this bug report we want to explicitly tell the librarian than a notice will be generate if a cancellation reason is selected. If the new checkbox we have a situation if the checkbox is selected and no reason selected => no notice will be generated This patch is not the optimal solution but answers the original need, without string changes (today is release day...) and without too many modifications in the code. Additional follow-up bug report must be opened to deal properly with this specific use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am really happy to have to deal with a checkbox on release day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114011|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 114030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114030&action=edit Bug 26282: Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114012|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 114031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114031&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114013|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 114032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114032&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114028|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 114033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114033&action=edit Bug 26282: Disable the checkbox if no reason selected On this bug report we want to explicitly tell the librarian than a notice will be generate if a cancellation reason is selected. If the new checkbox we have a situation if the checkbox is selected and no reason selected => no notice will be generated This patch is not the optimal solution but answers the original need, without string changes (today is release day...) and without too many modifications in the code. Additional follow-up bug report must be opened to deal properly with this specific use case. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 114034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114034&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Josef, I was in a chat with Martin. We were actually thinking about removing the notice template HOLD_CANCELLATION from the DB, for 20.11.00. That will disable the feature and let people create the notice template if needed. Then we will implement the real fix properly for 20.11.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114035&action=edit Bug 26282: (ALTERNATIVE) Remove HOLD_CANCELLATION notice We are really close to release, and the 'proper' fix to make the sending of hold cancellation notices optional will introduce string changes. This patch takes the alternative approach of removing the default notice template there by disabling the feature for 20.11.00 release and giving us time to properly impliment a solution and re-instate the default notice template for the 20.11.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this final alternative is the best approach given the release timing... If we all agree, I will happily transplant the other patches here to a new bug for 20.11.01 and go back and update the release note text for the two affected bugs now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Martin Renvoize from comment #37)
I think this final alternative is the best approach given the release timing...
If we all agree, I will happily transplant the other patches here to a new bug for 20.11.01 and go back and update the release note text for the two affected bugs now.
I do agree thanks Martin and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12656, 25534 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 [Bug 27103] Adding a hold cancellation reason should not always send a notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114016|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114015|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114031|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114247&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114032|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114248&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114249&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114015|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114250&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114016|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114251&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114252&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114034|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114253&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114254&action=edit Button approach -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114255&action=edit Checkbox aproach -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Two more followups to come.. one to restore the notices we nuked with bug 27103 and one to convert from a checkbox to a button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |koha-bugs@lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114259&action=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I don't think I'll manage to get to switching the checkbox implementation to a double button one.. Perhaps we can do that in a distinct bug along with cleaning up some of the forms. So.. I reckon this is read for SO/QA again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #50)
OK, I don't think I'll manage to get to switching the checkbox implementation to a double button one..
Perhaps we can do that in a distinct bug along with cleaning up some of the forms.
So.. I reckon this is read for SO/QA again
The checkbox is displayed even if the letter template does not exist. Should not we hide it? Should not we insert the template for new installs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114254|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114255|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call.. seems I missed some bits from that final commit.. I'll dig them out tomorrow.. As for bit displaying the checkbox.. are there precidents for that elsewhere? I'm happy to do it, but am also keen to have consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's how it works right now with the feature. It's disabled if the letter does not exist. And yes, behaviours being disabled if the letter template does not exist is what we are doing in other areas (claims, out of the top of my head). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Bug 26282 depends on bug 27103, which changed state. Bug 27103 Summary: Adding a hold cancellation reason should not always send a notice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Slowly working on this here: https://gitlab.com/mrenvoize/Koha/-/commits/bug_26282 It's slow going working through the various locations one can cancel a reservation from and updating the checkbox to optionally display/hide based on the existence of a notice template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114247|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115193&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114248|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115194&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114249|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115195&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114250|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115196&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114251|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115197&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114252|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115198&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114253|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115199&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114259|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115200&action=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115201&action=edit Bug 26282: Update pendingreserves to use buttons This patch updates circ/pendingreserves to use two buttons; "Cancel hold" and "Cancel hold and notify" for the pending reserves page. It will only display the notify option when a notice template exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Work to date uploaded.. still needs more followups but I wanted to make sure BZ was in sync with my gitlab before stepping away again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Kyle.. do you think you might have a chance to get back to this.. I'm not sure I will any time soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Wasn't this a "have to" for 20.11.01?... Looks like we completely forgot about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #64)
Work to date uploaded.. still needs more followups but I wanted to make sure BZ was in sync with my gitlab before stepping away again
What is still on the todo list? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Kyle M Hall from comment #67)
(In reply to Martin Renvoize from comment #64)
Work to date uploaded.. still needs more followups but I wanted to make sure BZ was in sync with my gitlab before stepping away again
What is still on the todo list?
I guess it's coming from comments 51-53. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115193|0 |1 is obsolete| | Attachment #115194|0 |1 is obsolete| | Attachment #115195|0 |1 is obsolete| | Attachment #115196|0 |1 is obsolete| | Attachment #115197|0 |1 is obsolete| | Attachment #115198|0 |1 is obsolete| | Attachment #115199|0 |1 is obsolete| | Attachment #115200|0 |1 is obsolete| | Attachment #115201|0 |1 is obsolete| | --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122448&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122449&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122450&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122451&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122452&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122453&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122454&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122455&action=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122456&action=edit Bug 26282: Show reason only if notice exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122550&action=edit Bug 26282: Update Holds to pull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Signed Off |Patch doesn't apply --- Comment #79 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Doesn't apply anymore :| -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122448|0 |1 is obsolete| | --- Comment #80 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138407&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122449|0 |1 is obsolete| | --- Comment #81 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138408&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122450|0 |1 is obsolete| | --- Comment #82 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138409&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138407|0 |1 is obsolete| | --- Comment #83 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138410&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138408|0 |1 is obsolete| | --- Comment #84 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138411&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138409|0 |1 is obsolete| | --- Comment #85 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138412&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122451|0 |1 is obsolete| | --- Comment #86 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138413&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122452|0 |1 is obsolete| | --- Comment #87 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138414&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122453|0 |1 is obsolete| | --- Comment #88 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138415&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122454|0 |1 is obsolete| | --- Comment #89 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138416&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122455|0 |1 is obsolete| | --- Comment #90 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138417&action=edit Bug 26282: (QA follow-up) Restore default notice Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122456|0 |1 is obsolete| | --- Comment #91 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138418&action=edit Bug 26282: Show reason only if notice exists Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122550|0 |1 is obsolete| | --- Comment #92 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138419&action=edit Bug 26282: Update Holds to pull Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #93 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Happy birthday, here is a rebase 🎁 ^o^ I compared the old and new patches to double check that I didn't change anything unknowingly. However failed QA because a test is failing and it's also failing when rebasing on an old(2021-08) master. So it's not from the rebase. #notmyjoblol root@kohadevbox:koha((e781542349...))$ prove t/db_dependent/Koha/Hold.t t/db_dependent/Koha/Hold.t .. 3/4 # Failed test 'GetPreparedLetter not called if notify_patron passed and no cancellation_reason passed' # at t/db_dependent/Koha/Hold.t line 290. # got: '1' # expected: '0' # Looks like you failed 1 test of 12. t/db_dependent/Koha/Hold.t .. 4/4 # Failed test 'cancel() tests' # at t/db_dependent/Koha/Hold.t line 297. # Looks like you failed 1 test of 4. t/db_dependent/Koha/Hold.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report ------------------- t/db_dependent/Koha/Hold.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 10 wallclock secs ( 0.04 usr 0.00 sys + 7.23 cusr 1.52 csys = 8.79 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138469&action=edit Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required, making this test invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141210&action=edit Bug 26282: (QA follow-up) Fix typo recieve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried testing this, but have run into 2 dead ends: * Manually added a HOLD_CANCELLATION notice * Added email address to my patron, created a bunch of holds * Verified the AV exists and has values * Verified my patron has a primary email set 1) From the patron account * Switch No to Yes for cancelling a hold * Choose reason, leave notify patron checked * Cancelled hold * Hold was cancelled, but: No notice was created 2) Record detail page, holds tab: * Click on "garbage can" - modal comes up without cancellation reason pull down or notify option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #96)
I tried testing this, but have run into 2 dead ends:
* Manually added a HOLD_CANCELLATION notice * Added email address to my patron, created a bunch of holds * Verified the AV exists and has values * Verified my patron has a primary email set
1) From the patron account * Switch No to Yes for cancelling a hold * Choose reason, leave notify patron checked * Cancelled hold * Hold was cancelled, but: No notice was created
2) Record detail page, holds tab: * Click on "garbage can" - modal comes up without cancellation reason pull down or notify option
I'd love to see this moving. We initially wanted to fix it right away after introducing the feature... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Until we find such time as to resurrect this, I just wanted to suggest that one could create one or more "SOMETYPE_NONOTICE" and wrap your notice in something like: [%- UNLESS reserves.cancellation_reason.match("NONOTICE") %] [%- END %] That cancelation notice type will end up being blank and thus won't get sent! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #98)
Until we find such time as to resurrect this, I just wanted to suggest that one could create one or more "SOMETYPE_NONOTICE" and wrap your notice in something like:
[%- UNLESS reserves.cancellation_reason.match("NONOTICE") %]
[%- END %]
That cancelation notice type will end up being blank and thus won't get sent!
Thx for the workaround :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Anni Rajala <anni.rajala@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.rajala@turku.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #100 from Anni Rajala <anni.rajala@turku.fi> --- This feature would be great, we'd be eager to test if this gets moving again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138410|0 |1 is obsolete| | Attachment #138411|0 |1 is obsolete| | Attachment #138412|0 |1 is obsolete| | Attachment #138413|0 |1 is obsolete| | Attachment #138414|0 |1 is obsolete| | Attachment #138415|0 |1 is obsolete| | Attachment #138416|0 |1 is obsolete| | Attachment #138417|0 |1 is obsolete| | Attachment #138418|0 |1 is obsolete| | Attachment #138419|0 |1 is obsolete| | Attachment #138469|0 |1 is obsolete| | Attachment #141210|0 |1 is obsolete| | --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171577&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171578&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171579&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171580&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171581&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171582&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171583&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171584&action=edit Bug 26282: (QA follow-up) Restore default notice Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171585&action=edit Bug 26282: Show reason only if notice exists Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171586&action=edit Bug 26282: Update Holds to pull Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171587&action=edit Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required, making this test invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171588&action=edit Bug 26282: (QA follow-up) Fix typo recieve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171589&action=edit Bug 26282: (QA follow-up) Tidy code for qa script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171590&action=edit Bug 26282: (QA follow-up) Fix typo cancelation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171577|0 |1 is obsolete| | Attachment #171578|0 |1 is obsolete| | Attachment #171579|0 |1 is obsolete| | Attachment #171580|0 |1 is obsolete| | Attachment #171581|0 |1 is obsolete| | Attachment #171582|0 |1 is obsolete| | Attachment #171583|0 |1 is obsolete| | Attachment #171584|0 |1 is obsolete| | Attachment #171585|0 |1 is obsolete| | Attachment #171586|0 |1 is obsolete| | Attachment #171587|0 |1 is obsolete| | Attachment #171588|0 |1 is obsolete| | Attachment #171589|0 |1 is obsolete| | Attachment #171590|0 |1 is obsolete| | --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171592&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 171593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171593&action=edit Bug 26282: (QA follow-up) Tidy code for qa script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Patches squashed for readability. Final tidy kept separate to prevent future rebase issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Needs Signoff |Failed QA --- Comment #118 from Phil Ringnalda <phil@chetcolibrary.org> --- This poor bug. I really wanted to sign off, but something, probably Bootstrap5, has made the cancellation popup in reserves/request.tt too narrow to reasonably display the checkbox unless your cancellation reasons are quite terse. With the default data, I get Cancellation reason [ No reason given ⌄ ] [ ] Notify patron and a checkbox on one line and the label on another is ungood. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is indeed a poor bug and major too. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #120 from Phil Ringnalda <phil@chetcolibrary.org> --- Handy solution to the wrapping between checkbox and label back in comment 18 - use two buttons, Cancel and Cancel and notify, rather than one button with different behavior based on a checkbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices.
Good reason to make that one digestable in the future? Plugging Bug 37760 here. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #122 from Jonathan Druart <jonathan.druart@gmail.com> --- I am currently adding MockModule call to tests to prevent warnings. If ever this notice template is added, we will need to remove them. "# Prevent warning 'No reserves HOLD_CANCELLATION letter transported by email'" See bug 40372, bug 40373. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org