[Bug 10184] New: Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Bug ID: 10184 Summary: Circulation History reverses sort order Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The script members/readingrec.pl specifically requests the users issues ordered with the most recent (by due date) first. But they are displayed in approximately the reverse order to this. The cause is that unless explicitly disabled the datatables sort their data and not being given a specification they do so in ascending order by the first column. The pre display sort of already sorted data needs disabling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 17933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17933&action=edit proposed patch Patch: to test Without the patch issues in patron circulation history will show oldest first. With patch applied issues will initially display most recent first (ordered by duedate) Users ability to sort the table should not be impaired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- oops forgot to change status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think the added line should be: "aaSorting": [[8, "desc"]] ...so that the sorted column reflects the sort state in the column header. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to comment #3)
I think the added line should be:
"aaSorting": [[8, "desc"]]
...so that the sorted column reflects the sort state in the column header.
Does this not add an unnecessary re-sort, the data is sorted unless the user selects to resort it no further processing is required -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- The sorting algorithm doesn't take into account the 'dateformat' system preference. We just have a string sort. It works when dateformat = yyyy/mm/dd. It doesn't for dd/mm/yyyy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to comment #5)
The sorting algorithm doesn't take into account the 'dateformat' system preference. We just have a string sort. It works when dateformat = yyyy/mm/dd. It doesn't for dd/mm/yyyy.
The sort is done by mysql on a mysql date column the koha system preference is not relevant. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #7 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Status has been marked as failed QA but I cant see under what basis? Patch is stalled as a result and bug is out in the wild can someone clarify -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I set to "Failed QA" because of the issue with the table header sort indicator. I see your point about the forced re-sort. In my tests there was a minor difference in processing time, but I didn't test with an account with a large history (only ~120). The indicator is a minor point, so I'll give the re-sort question the benefit of the doubt and say it's not worth the extra processing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17933|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18383&action=edit [SIGNED-OFF] Bug 10184 - Circulation History reverses sort order Issue data is passed to the readingrec template ordered most recent due date first. Datatables unless specified otherwise do a presort on the data they will display the default results in an order the reverse of what was intended. Disabling the presort preserves the initial sort order until the user selects a different sort http://bugs.koha-community.org/show_bug.cgi?id=10184 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18383|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18410&action=edit Bug 10184 - Circulation History reverses sort order Issue data is passed to the readingrec template ordered most recent due date first. Datatables unless specified otherwise do a presort on the data they will display the default results in an order the reverse of what was intended. Disabling the presort preserves the initial sort order until the user selects a different sort Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #14 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org