https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68574&action=edit Bug 19530: Added commentary for last test when prove -v Before patch, prove -v had no comment for the last test. After patch, it says something in line with second last test. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $dbh->do("UPDATE branchtransfers SET datearrived = NOW(), comments = ? WHERE itemnumber = ?", undef, "Canceled, new transfer from $frombranch to $tobranch created", $itemnumber); We should at least limit this update by adding datearrived IS NULL. No need to update here all arrived items. In this case you might even wonder if you should not DELETE those records instead? I am wondering if transferbook (the sub calling ModItemTransfer) should check if there is no open transfer in the table. It is possible to add multiple transfers by selecting different destinations. What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5)

$dbh->do("UPDATE branchtransfers SET datearrived = NOW(), comments = ? WHERE itemnumber = ?", undef, "Canceled, new transfer from $frombranch to $tobranch created", $itemnumber);

We should at least limit this update by adding datearrived IS NULL. No need to update here all arrived items. In this case you might even wonder if you should not DELETE those records instead? I am wondering if transferbook (the sub calling ModItemTransfer) should check if there is no open transfer in the table. It is possible to add multiple transfers by selecting different destinations. What do you think?

Good idea. I'll submit a followup for that! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71066&action=edit Bug 19530 - Don't update the date arrived for closed transfers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> ---

...

I am wondering if transferbook (the sub calling ModItemTransfer) should check if there is no open transfer in the table. It is possible to add multiple transfers by selecting different destinations. What do you think?

I'm not sure what you mean. How do you select multiple destination? Do you mean to give feedback that a previous transfer was closed? If so I think we should put that out of scope for this bug and create a new bug report to add user feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68573|0 |1 is obsolete| | Attachment #71065|0 |1 is obsolete| | Attachment #71066|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71235&action=edit Bug 19530: Prevent multiple transfers from existing for one item We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. Test Plan: 1) prove t/db_dependent/Circulation/transfers.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71237&action=edit Bug 19530: Don't update the date arrived for closed transfers Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sounds like something is going wrong before that point and we are going to hide the problem. Should not we add a debug message to the logs with some useful information? Marcel, are you ok to push it? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)

Sounds like something is going wrong before that point and we are going to hide the problem. Should not we add a debug message to the logs with some useful information?

Marcel, are you ok to push it?

Yes, ok. But we could indeed add a warn, because we are combatting symptoms.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)

(In reply to Kyle M Hall from comment #0)

...

We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one.

Kyle, can you give more details please? Which version? On only 1 installation or more? Using other developments (fork)?

It's happened on a few partners. No changes to the code. We just were unable to figure out how the librarians were cause the issue. It's been happening for the 16.x and 17.x at the very least, possibly longer. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #20 from NancyK. <nkeener@washoecounty.us> --- We noticed this when we went to 17.05. If an item on hold gets put in transit, but is thrown in the wrong bin and gets sent to the wrong library, when they check the item in, it stays in transit. That's different behavior. They are used to being able to just put it in transit again to the correct library. When that second in-transit happens its chaos. NancyK Washoe County Library System -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20885 -- You are receiving this mail because: You are watching all bug changes.