[Bug 20951] New: Koha::Patron::Discharge is missing use Koha::Patron::Debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Bug ID: 20951 Summary: Koha::Patron::Discharge is missing use Koha::Patron::Debarments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Koha::Patron::Discharge is missing use Koha::Patron::Debarments used in discharge() method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 76093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76093&action=edit Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 [Bug 20953] Discharge can be requested several times on OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't reproduce the problem. I have tried discharging from the patron account as well as discharging using the link from the dashboard and the 'allow' button. Similar to bug 20851? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76093|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76167&action=edit Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=20953 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76167|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76194&action=edit Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_18_05_candidate | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
I can't reproduce the problem. I have tried discharging from the patron account as well as discharging using the link from the dashboard and the 'allow' button.
Similar to bug 20851?
I should have mentioned I'm in Plack env. I see the explanation in Bug 20851. I think each module should explicitly call use on the modules they need. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org