[Bug 39315] New: Missing tests for KohaTable search on coded value's description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Bug ID: 39315 Summary: Missing tests for KohaTable search on coded value's description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 39011 On bug 39011 we added the ability to search on the coded value description, but the changes have not been covered by tests. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39011 [Bug 39011] Unable to search the holdings table (except home/holding libraries and barcode) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |38108 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Depends on Cypress tests from bug 38108. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 [Bug 38108] Make display of table filters in staff interface holdings table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179201&action=edit Bug 39315: Move KohaTable cypress tests to a separate directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179202&action=edit Bug 39315: Move holdings Cypress tests to a separate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179203&action=edit Bug 39315: MockData - generate full objects for libraries and item types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179204&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179201|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 179365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179365&action=edit Bug 39315: Move KohaTable cypress tests to a separate directory Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179202|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 179366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179366&action=edit Bug 39315: Move holdings Cypress tests to a separate file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179203|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 179367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179367&action=edit Bug 39315: MockData - generate full objects for libraries and item types Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179204|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 179368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179368&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. When applying patches for dependency 38108, use interactive mode and comment out all patches except the last one (Add Cypress tests), otherwise the patches don't apply cleanly (all the other patches for the dependency are already in main). 2. Running the tests - these should all pass (there was an incorrect path in the test plan for PatronSearch_spec.ts): - yarn cypress run --spec t/cypress/integration/t/mockData.ts - yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts - yarn cypress run --spec t/cypress/integration/KohaTable/KohaTable_spec.ts - yarn cypress run --spec t/cypress/integration/KohaTable/PatronSearch_spec.ts 3. When I run the tests in step 2, they all pass. However, I get this error (both before and after): DevTools listening on ws://127.0.0.1:40643/devtools/browser/4b47ab3b-14a7-4a1f-ac7d-cb9008446e76 [9571:0316/171820.196254:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported. Missing baseUrl in compilerOptions. tsconfig-paths will be skipped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Failed QA --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hmm.. QA script doesn't like something here: FAIL t/cypress/integration/KohaTable/Holdings_spec.ts FAIL forbidden patterns forbidden pattern: .only detected (line 272) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179368|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 180285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180285&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #11)
Hmm.. QA script doesn't like something here:
FAIL t/cypress/integration/KohaTable/Holdings_spec.ts FAIL forbidden patterns forbidden pattern: .only detected (line 272)
Oops sorry about that. I knew it was a good idea to add this test :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179365|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 180317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180317&action=edit Bug 39315: Move KohaTable cypress tests to a separate directory Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179366|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 180318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180318&action=edit Bug 39315: Move holdings Cypress tests to a separate file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179367|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 180319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180319&action=edit Bug 39315: MockData - generate full objects for libraries and item types Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180285|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 180320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180320&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180317|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180371&action=edit Bug 39315: Move KohaTable cypress tests to a separate directory Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180318|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180372&action=edit Bug 39315: Move holdings Cypress tests to a separate file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180319|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180373&action=edit Bug 39315: MockData - generate full objects for libraries and item types Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180320|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180374&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Tests, tests, all the tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180371|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180386&action=edit Bug 39315: Move KohaTable cypress tests to a separate directory Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180372|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180387&action=edit Bug 39315: Move holdings Cypress tests to a separate file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180373|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180388&action=edit Bug 39315: MockData - generate full objects for libraries and item types Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180374|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180389&action=edit Bug 39315: (bug 38108 follow-up) Add Cypress tests 1. We move from const to var so that we can modify the value of the variable from the Cypress tests. 2. Also remove win.libraries_map as it seems that our code is no longer failing if it's missing (we added more checks I guess) 3. Improved selectors for the show/hide filters links - cy.get(".hide_filters").click(); + cy.get(`.${table_id}_table_controls .hide_filters`).click(); Test plan: Both commands should pass yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts yarn cypress run --spec t/cypress/integration/t/mockData.ts Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Bug 39315 depends on bug 38108, which changed state. Bug 38108 Summary: Make display of table filters in staff interface holdings table configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38108 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #29 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39315 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #30 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org