[Bug 25138] New: Terminology: Point of sale should use library instead of branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Bug ID: 25138 Summary: Terminology: Point of sale should use library instead of branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There are some branches scattered around that should be libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102890&action=edit Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- If you don't have a cash register set up (or you have archived the cash register for the library) and click on either: - 'Point of sale' from the main staff interface page (/cgi-bin/koha/pos/pay.pl) or - the 'Register details' page (/cgi-bin/koha/pos/register.pl) the message text has branch instead of libary: "You must have at least one cash register associated with this branch before you can record payments." Apart from that, everything else works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 103070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103070&action=edit Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch It has also been applied to the Register details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103070|0 |1 is obsolete| | --- Comment #4 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 103076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103076&action=edit Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102890|0 |1 is obsolete| | --- Comment #5 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 103077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103077&action=edit Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice catch - thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #7 from David Nind <david@davidnind.com> --- Ignore half of comment 2 - was posted just before the follow-up patch was made and signed off! However, text change still required for /cgi-bin/koha/pos/pay.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103077|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103138&action=edit Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103076|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103139&action=edit Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103194&action=edit Bug 25138: (follow-up) Point of sale should use library instead of branch Fixes a misssed occurence on the pay.tt page. To test: - Don't have a cash register set up (or you have archived the cash register for the library) - Go to 'Point of sale' from the main staff interface page - Verify library/branch in the note shown: You must have at least one cash register associated with this library before you can record payments. https://bugs.koha-community.org/show_bug.cgi?id=24138 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sneaking in a follow-up here for the one word change on pay.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 --- Comment #13 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #12)
Sneaking in a follow-up here for the one word change on pay.tt
Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes menu items and release notes| |messages for the point of | |sale feature so that it | |uses 'library' instead of | |'branch'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|additional_work_needed | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #11)
Created attachment 103194 [details] [review] Bug 25138: (follow-up) Point of sale should use library instead of branch
Fixes a misssed occurence on the pay.tt page.
To test: - Don't have a cash register set up (or you have archived the cash register for the library) - Go to 'Point of sale' from the main staff interface page - Verify library/branch in the note shown:
You must have at least one cash register associated with this library before you can record payments.
This has been pushed on Apr 17 commit 54630c842e800efefd95a4facf9907cd29a5b9cb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org