http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ I don't consider a patch should fail qa if it does not use DBIC since we don't have any recommendation on how to integrate it into Koha scripts/modules at the moment. 2/ You use a new way for ordering dates in a table, I would prefer to keep the usual method (using span title). 3/ It would be great if the variable names in the module match the DB field names (for instance record_id vs recordid vs recid). Not blocker. 4/ These patch use implicit use of conditionals: * $a || return; * defined($a) || do { some assignment }; I am not sure we have coding guidelines about that but I really would prefer the code being consistent. * return if $a; * if ( defined($a) ) { some assignment; } Not blocker. I will provide a follow-up for 2. Mared as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.