[Bug 11504] New: Untranslatable "Item Type" or "Collection Code" in branch transfer limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Bug ID: 11504 Summary: Untranslatable "Item Type" or "Collection Code" in branch transfer limits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The string "Item Type" or "Collection Code" shows up in branch transfer limits, eg. in the text "For all Item Types:", and does not come via the i18n toolchain. The text is hard-coded in admin/branch_transfer_limits.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30805&action=edit Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits This patch makes reported strings translatable. To test: 1. Go to Administration > Library transfer limits 2. Depending on the value of BranchTransferLimitsType your may see in a box: a) For *all* Collection codes: b) For *all* Item types: change system preference to show both values 3. Update translation files for your preferred language check new entry msgid "%sCollection codes%sItem types%s: " Not pretty but can be translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Patch complexity|--- |Trivial patch Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|enhancement |minor --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry, apply the patch and then follow test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30805|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30811&action=edit Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits This patch makes reported strings translatable. To test: 1. Go to Administration > Library transfer limits 2. Depending on the value of BranchTransferLimitsType your may see in a box: a) For *all* Collection codes: b) For *all* Item types: change system preference to show both values 3. Update translation files for your preferred language check new entry msgid "%sCollection codes%sItem types%s: " Not pretty but can be translated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30811|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30840&action=edit [PASSED QA] Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits This patch makes reported strings translatable. To test: 1. Go to Administration > Library transfer limits 2. Depending on the value of BranchTransferLimitsType your may see in a box: a) For *all* Collection codes: b) For *all* Item types: change system preference to show both values 3. Update translation files for your preferred language check new entry msgid "%sCollection codes%sItem types%s: " Not pretty but can be translated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I have to confess that I lower cased the collections and item types as they appear in a sentence. No other changes made and this works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org