[Bug 27432] New: Add report run to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Bug ID: 27432 Summary: Add report run to action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Reports run should be logged in action logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod@lib.auth.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 [Bug 14024] Add reports to action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26669 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115162&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- If accepted I'll create a patch to edit ReportsLog syspref description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115162|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115184&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frido, we have a fail in the QA tools here: FAIL C4/Reports/Guided.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Also, can you please update the system preference description? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115926&action=edit Bug 27432: (QA follow-up) fix if report_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115927&action=edit Bug 27432: Update ReportsLog system preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Hi Frido,
we have a fail in the QA tools here:
FAIL C4/Reports/Guided.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Done. I will be more careful in the future ;)
Also, can you please update the system preference description?
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117355&action=edit Bug 27432: (follow-up) Correct grammar of preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115184|0 |1 is obsolete| | --- Comment #9 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 117356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117356&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115926|0 |1 is obsolete| | --- Comment #10 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 117357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117357&action=edit Bug 27432: (QA follow-up) fix if report_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115927|0 |1 is obsolete| | --- Comment #11 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 117358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117358&action=edit Bug 27432: Update ReportsLog system preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel something is out of order here - patches don't apply in the current sequence. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27432: (follow-up) Correct grammar of preference description error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref). error: could not build fake ancestor Patch failed at 0001 Bug 27432: (follow-up) Correct grammar of preference description The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27432-follow-up-Correct-grammar-of-preference--qT_FEt.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #12)
I feel something is out of order here - patches don't apply in the current sequence.
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27432: (follow-up) Correct grammar of preference description error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref). error: could not build fake ancestor Patch failed at 0001 Bug 27432: (follow-up) Correct grammar of preference description The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27432-follow-up-Correct-grammar-of-preference--qT_FEt.patch
Ah indeed, patch : Bug 27432: (follow-up) Correct grammar of preference description Is from 17:45 and other patches are from 17:54. I think this patch must be moved after main patch : Bug 27432: Add report run to action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tried to apply patches 2 3 4 as attached, but I still have a conflict that needs to be solved by the dev: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 27432: Add report run to action logs Applying: Bug 27432: (QA follow-up) fix if report_id Applying: Bug 27432: Update ReportsLog system preference description error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref). error: could not build fake ancestor Patch failed at 0001 Bug 27432: Update ReportsLog system preference description The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27432-Update-ReportsLog-system-preference-desc-Ygc9OB.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Mhh strange rebase does not work. I simply fix my commit : Bug 27432: Update ReportsLog system preference description With patch (manually set to obsolete) : Bug 27432: (follow-up) Correct grammar of preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117356|0 |1 is obsolete| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 118953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118953&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117357|0 |1 is obsolete| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 118954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118954&action=edit Bug 27432: (QA follow-up) fix if report_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117358|0 |1 is obsolete| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 118955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118955&action=edit Bug 27432: Update ReportsLog system preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118953|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119817&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118954|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119818&action=edit Bug 27432: (QA follow-up) fix if report_id Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118955|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119819&action=edit Bug 27432: Update ReportsLog system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also checked that these can be found with the log viewer tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Missing test coverage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Version(s)| |Reports run are now logged released in| |in Tools > Logs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #24 from David Cook <dcook@prosentient.com.au> --- I would love to see this get through. What do we need to do to push this along? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- We need a unit test. Maybe in t/db_dependent/Log.t. Actually there are no test for other reports actions right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #26 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #25)
We need a unit test. Maybe in t/db_dependent/Log.t.
Actually there are no test for other reports actions right ?
That's what I was wondering too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we get some help here with the unit tests? Would make a real nice addition. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is no difficulty in writing the require tests. Let me know if you need guidance however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that we should not fetch the report if ReportsLog is off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #29)
Note that we should not fetch the report if ReportsLog is off. Correct.
I see in execute_query() : my ( $is_sql_valid, $errors ) = Koha::Report->new({ savedsql => $sql })->is_sql_valid; return (undef, @{$errors}[0]) unless $is_sql_valid; Should we replace with : my $report = Koha::Reports->find($report_id) if $report_id; ... $report->is_sql_valid Plus : ====== I see an issue with this feature. Some public reports maybe run very often via JSON, like webservices. Maybe we should log only runs via the staff interface ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Eric Swenson <eric@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #31 from Eric Swenson <eric@bywatersolutions.com> --- Seeing when the report was run from the staff interface would solve one issue for a partner library. Would the running of cronned reports that email out the results also be viewable since they use runreport.pl? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Stephanie <stephaniej@cctexas.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephaniej@cctexas.com --- Comment #32 from Stephanie <stephaniej@cctexas.com> --- For the report patch, are there any scheduled enhancements that can give you the profile that ran reports? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz@helsi | |nki.fi --- Comment #33 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- This would be an important addition to Koha logs, from GDPR perspective. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Reports run are now logged release notes| |in Tools > Logs. Version(s)|Reports run are now logged | released in|in Tools > Logs. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119817|0 |1 is obsolete| | --- Comment #34 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186046&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119818|0 |1 is obsolete| | --- Comment #35 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186047&action=edit Bug 27432: (QA follow-up) fix if report_id Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119819|0 |1 is obsolete| | --- Comment #36 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186048&action=edit Bug 27432: Update ReportsLog system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #37 from Brendan Lawlor <blawlor@clamsnet.org> --- Our consortium would really like to be able to see this in the logs. I rebased the patches for current main, tested and confirmed it works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186046|0 |1 is obsolete| | Attachment #186047|0 |1 is obsolete| | Attachment #186048|0 |1 is obsolete| | --- Comment #38 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186997&action=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #39 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186998&action=edit Bug 27432: (QA follow-up) fix if report_id Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #40 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186999&action=edit Bug 27432: Update ReportsLog system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@openfifth.co. | |uk --- Comment #41 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 40649 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |lucas@bywatersolutions.com --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- C4/Reports/Guided.pm is not tidy. Also the sys pref description should be: "when reports are added, deleted, changed, or ran." instead of: "when reports are added, deleted, changed, or run." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add report run to action |Add reports run to action |logs |logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186997|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #43 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 190698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190698&action=edit Bug 27432: Add reports run to action logs Reports run should be logged in action logs. This uses the exisiting action "Run" from cronjobs. Like for other actions, infos contains the report name ("Unknown report" is no report id provided) and executed SQL query. 1) Apply patch 2) Enable system preference "ReportsLog" 3) Run a report 4) Go to Tools > Log viewer 5) Select module "Reports" and submit 6) Check you see a log with report name and SQL query 7) Change SQL of report, re-run 8) Go to Tools > Log viewer 9) Select module "Reports" and submit 10) Select the 2 logs "Compare" and click "View comparison" Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #44 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass (lukeg) from comment #42)
C4/Reports/Guided.pm is not tidy.
Fixed after squashing patches.
Also the sys pref description should be:
"when reports are added, deleted, changed, or ran."
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Chris Rowlands <chris.rowlands6@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.rowlands6@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #45 from mteal@greenvillelibrary.org --- This would be great to get added. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org