[Bug 16272] New: Transform checkout from on-site checkout to regular checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Bug ID: 16272 Summary: Transform checkout from on-site checkout to regular checkout Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com At the BULAC library, patrons may ask more one-site checkouts than regular checkouts. Often they request a bunch of books from the stacks, get them checked out as on-site checkouts, consult them. Eventually they come back to the desk asking to check in books they are not interested in and transform their on-site checkout to regular checkouts on books they wish to bring home. We would like to have a quick way to do this on the intranet: by checkin out an item which is on-site checked out for the same borrower, we would like the loan to become a regular check out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50606&action=edit Bug 16272: Automatically switch an on-site checkout to a regular checkout when checked out Use case: A patron checks some items out on-site and want to take it home. To facilitate the librarian work the checkout is directly switched from on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is on. Test plan: 0/ Let the new pref SwitchOnSiteCheckouts off 1/ Checkout one items to a patron and tick the "on-site checkout" checkbox 2/ Check the same item out without ticking the "on-site checkout" checkbox => You should get "This item can not be renewed, it's an on-site checkout" 3/ Switch the pref on 4/ Repeat 2 => The on-site checkout should be automatically switched to a regular checkout Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50607&action=edit Bug 16272: Specific case when switching an on-site checkout to a regular checkout In the case on-site checkouts are considered as a regular checkout in issuing rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on): When after the on-site checkout the maximum limit of checkouts is reached and the patron wants to switch an on-site checkout to a regular checkout, the C4::Circulation::TooMany subroutine will return a TOO_MANY_CHECKOUTS error. To avoid that, we need to allow an extra checkout in this subroutine. Test plan: 0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts on 1/ In the issuing rules, set the total number of checkouts (maxissueqty) to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty) 2/ Check 2 items out ticking the 'on-site checkout' checkbox 3/ Check one of these items out, to automatically switch it to a regular checkout => The checkout should be allowed. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50606|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 51331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51331&action=edit Bug 16272: Automatically switch an on-site checkout to a regular checkout when checked out Use case: A patron checks some items out on-site and want to take it home. To facilitate the librarian work the checkout is directly switched from on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is on. Test plan: 0/ Let the new pref SwitchOnSiteCheckouts off 1/ Checkout one items to a patron and tick the "on-site checkout" checkbox 2/ Check the same item out without ticking the "on-site checkout" checkbox => You should get "This item can not be renewed, it's an on-site checkout" 3/ Switch the pref on 4/ Repeat 2 => The on-site checkout should be automatically switched to a regular checkout Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> With small changes to apply to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51331|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 51332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51332&action=edit Bug 16272: Automatically switch an on-site checkout to a regular checkout when checked out Use case: A patron checks some items out on-site and want to take it home. To facilitate the librarian work the checkout is directly switched from on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is on. Test plan: 0/ Let the new pref SwitchOnSiteCheckouts off 1/ Checkout one items to a patron and tick the "on-site checkout" checkbox 2/ Check the same item out without ticking the "on-site checkout" checkbox => You should get "This item can not be renewed, it's an on-site checkout" 3/ Switch the pref on 4/ Repeat 2 => The on-site checkout should be automatically switched to a regular checkout Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> With small changes to apply to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50607|0 |1 is obsolete| | --- Comment #5 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 51333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51333&action=edit Bug 16272: Specific case when switching an on-site checkout to a regular checkout In the case on-site checkouts are considered as a regular checkout in issuing rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on): When after the on-site checkout the maximum limit of checkouts is reached and the patron wants to switch an on-site checkout to a regular checkout, the C4::Circulation::TooMany subroutine will return a TOO_MANY_CHECKOUTS error. To avoid that, we need to allow an extra checkout in this subroutine. Test plan: 0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts on 1/ In the issuing rules, set the total number of checkouts (maxissueqty) to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty) 2/ Check 2 items out ticking the 'on-site checkout' checkbox 3/ Check one of these items out, to automatically switch it to a regular checkout => The checkout should be allowed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Smallish conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51332|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54498&action=edit Bug 16272: Automatically switch an on-site checkout to a regular checkout when checked out Use case: A patron checks some items out on-site and want to take it home. To facilitate the librarian work the checkout is directly switched from on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is on. Test plan: 0/ Let the new pref SwitchOnSiteCheckouts off 1/ Checkout one items to a patron and tick the "on-site checkout" checkbox 2/ Check the same item out without ticking the "on-site checkout" checkbox => You should get "This item can not be renewed, it's an on-site checkout" 3/ Switch the pref on 4/ Repeat 2 => The on-site checkout should be automatically switched to a regular checkout Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> With small changes to apply to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51333|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54499&action=edit Bug 16272: Specific case when switching an on-site checkout to a regular checkout In the case on-site checkouts are considered as a regular checkout in issuing rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on): When after the on-site checkout the maximum limit of checkouts is reached and the patron wants to switch an on-site checkout to a regular checkout, the C4::Circulation::TooMany subroutine will return a TOO_MANY_CHECKOUTS error. To avoid that, we need to allow an extra checkout in this subroutine. Test plan: 0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts on 1/ In the issuing rules, set the total number of checkouts (maxissueqty) to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty) 2/ Check 2 items out ticking the 'on-site checkout' checkbox 3/ Check one of these items out, to automatically switch it to a regular checkout => The checkout should be allowed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #6)
Smallish conflict in C4/Circulation.pm
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- For the special case, if a default rule is set in addition to the circ rule then the onsite checkout to change to a regular checkout still activates a too many warning I think you need the delta at the lines below as well 539 if ( C4::Context->preference('ConsiderOnSiteCheckoutsAsNormalCheckouts') ) { 540 if ( $checkout_count >= $max_checkouts_allowed ) { 541 return { 542 reason => 'TOO_MANY_CHECKOUTS', 543 count => $checkout_count, 544 max_allowed => $max_checkouts_allowed, 545 }; 546 } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54523&action=edit Bug 16272: (follow-up) Specific case when switching an on-site checkout to a regular checkout Same as previous patch but if another circ rule exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54524&action=edit Bug 16272: Add description for tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #10)
For the special case, if a default rule is set in addition to the circ rule then the onsite checkout to change to a regular checkout still activates a too many warning
I think you need the delta at the lines below as well
Good catch! Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54498|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54526&action=edit Bug 16272: Automatically switch an on-site checkout to a regular checkout when checked out Use case: A patron checks some items out on-site and want to take it home. To facilitate the librarian work the checkout is directly switched from on-site to regular when checked out if the new pref SwitchOnSiteCheckouts is on. Test plan: 0/ Let the new pref SwitchOnSiteCheckouts off 1/ Checkout one items to a patron and tick the "on-site checkout" checkbox 2/ Check the same item out without ticking the "on-site checkout" checkbox => You should get "This item can not be renewed, it's an on-site checkout" 3/ Switch the pref on 4/ Repeat 2 => The on-site checkout should be automatically switched to a regular checkout Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> With small changes to apply to master. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54499|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54527&action=edit Bug 16272: Specific case when switching an on-site checkout to a regular checkout In the case on-site checkouts are considered as a regular checkout in issuing rules (i.e. ConsiderOnSiteCheckoutsAsNormalCheckouts is on): When after the on-site checkout the maximum limit of checkouts is reached and the patron wants to switch an on-site checkout to a regular checkout, the C4::Circulation::TooMany subroutine will return a TOO_MANY_CHECKOUTS error. To avoid that, we need to allow an extra checkout in this subroutine. Test plan: 0/ Switch ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts on 1/ In the issuing rules, set the total number of checkouts (maxissueqty) to 2 and the number of on-site checkouts to 2 (maxonsiteissueqty) 2/ Check 2 items out ticking the 'on-site checkout' checkbox 3/ Check one of these items out, to automatically switch it to a regular checkout => The checkout should be allowed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54523|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54528&action=edit Bug 16272: (follow-up) Specific case when switching an on-site checkout to a regular checkout Same as previous patch but if another circ rule exists Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54524|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54529&action=edit Bug 16272: Add description for tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 54579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54579&action=edit Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54579|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 54580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54580&action=edit Bug 16272 [QA Followup] - Indexer fails on indexing temparary testing records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17345 [Bug 17345] Typo in sysprefs.sql prevents all systempreferences from being installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A patron checks some items release notes| |out on-site and want to | |take it home. | |To facilitate | |the librarian work the | |checkout is directly | |switched from on-site to | |regular when checked out if | |the new pref | |SwitchOnSiteCheckouts is | |on. | |If | |SwitchOnSiteCheckouts is | |off and you check out an | |item with "on-site | |checkout" you receive an | |"This item can not be | |renewed, it's an on-site | |checkout". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 [Bug 18321] One more checkouts possible than allowed by rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 [Bug 26583] Unnecessary code in AddIssue -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org