[Bug 28838] New: SCO impossible errors are hard to target with CSS/JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Bug ID: 28838 Summary: SCO impossible errors are hard to target with CSS/JS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On sco-main.tt if a patron checks out something that is 'impossible' to check out via SCO they are presented with one of many reasons why the item cannot be checked out: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. If we could wrap each of these messages in a span with a unique ID it will be easier to change text/target each individual message with CSS/JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123700&action=edit Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds unique ID's release notes| |to the SCO main page so the | |impossible errors can | |easily be targeted via JS | |and CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123700|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123781&action=edit Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds unique ID's |This patch adds unique IDs release notes|to the SCO main page so the |to the SCO main page so the |impossible errors can |impossible errors can |easily be targeted via JS |easily be targeted via JS |and CSS. |and CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123781|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124227&action=edit Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a <span> with an ID. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org