[Bug 22475] New: Shelving location doesn't appear on tags list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Bug ID: 22475 Summary: Shelving location doesn't appear on tags list view Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tags/list.pl?tag=foo OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 22422 Target Milestone: --- In the staff client, when viewing a list of titles with a particular tag, shelving location is supposed to appear but doesn't. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 [Bug 22422] improve item location display with class "shelvingloc" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86281&action=edit Bug 22475: Shelving location doesn't appear on tags list view This patch corrects the tags list view so that shelving location appears correctly. Previously the template tried to display a variable which was empty. To test, apply the patch and locate an title which has both a tag applied to it and a shelving location defined for one or more items. Go to Tools -> Tags and click the tag to view titles with that tag. In the location column of the table the shelving location should appear along with library and call number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- When I try to apply the patch, I have an error message : Applying: Bug 22475: Shelving location doesn't appear on tags list view fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Did you apply the patch for Bug 22422 first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86281|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87425&action=edit Bug 22475: Shelving location doesn't appear on tags list view This patch corrects the tags list view so that shelving location appears correctly. Previously the template tried to display a variable which was empty. To test, apply the patch and locate an title which has both a tag applied to it and a shelving location defined for one or more items. Go to Tools -> Tags and click the tag to view titles with that tag. In the location column of the table the shelving location should appear along with library and call number. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87425|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87427&action=edit Bug 22475: Shelving location doesn't appear on tags list view This patch corrects the tags list view so that shelving location appears correctly. Previously the template tried to display a variable which was empty. To test, apply the patch and locate an title which has both a tag applied to it and a shelving location defined for one or more items. Go to Tools -> Tags and click the tag to view titles with that tag. In the location column of the table the shelving location should appear along with library and call number. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No need to backport this one further chaps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Bug 22475 depends on bug 22422, which changed state. Bug 22422 Summary: improve item location display with class "shelvingloc" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org