[Bug 10754] New: HomeOrHoldingBranch and CircControl are described identically in the system preference editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Bug ID: 10754 Summary: HomeOrHoldingBranch and CircControl are described identically in the system preference editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 20451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20451&action=edit screenshot of system preference editor We have 2 system preferences that from their description in the system preferences editor do exactly the same thing, but offer different options: CircControl: Use the checkout and fines rules of ... - the library the item is from - the library the patron is from - the library you are logged in at HomeOrHoldingBranch: Use the checkout and fines rules of ... - the ibrary the item is from - the library the item was checked out from In the systempreferences table the description is different: CircControl: Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability HomeOrHoldingBranch: Specify the agency that controls the circulation and fines policy Both preferences are used a multiple times in the code. I am currently not sure what the difference is. Bug 5159 also claims that CircControl is not only used when independentbranches is turned on. Can someone clarify and help updating the documentation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5159 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #1 from mathieu saby <mathsabypro@gmail.com> --- Bug still here in 3.14.3 Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #2 from mathieu saby <mathsabypro@gmail.com> --- I'm tyring to set up a new Koha instance, and I don't know at all what to do with those 2 prefs :( Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- For the most part the system goes like this for selecting circulation rules: If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used. Also, from my reading of master, it appears that the system preference in question is HomeOrHoldingBranch, not CircControl. That is, if IndependentBranches is enabled, and the item's branchcode does not match the logged in library branchcode ( the choosing of which is via HomeOrHoldingBranch ), the item cannot be issued ( unless you are a super-librarian ). Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- For the most part the system goes like this for selecting circulation rules: 1) If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode 2) If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode 3) If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used. Also, if IndependentBranches is enabled, and the item's branchcode ( the choosing of which is via HomeOrHoldingBranch ) does not match the logged in library branchcode , the item cannot be issued ( unless you are a super-librarian ). Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Ignore comment 3, I rewrote it as comment 4 to make it more readable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- I updated the manual (changes will be available tomorrow) to note these differences - please let me know if I should edit them: http://manual.koha-community.org/3.18/en/administration.html#CircControl http://manual.koha-community.org/3.18/en/administration.html#HomeOrHoldingBr... http://manual.koha-community.org/3.18/en/patscirc.html#circfinerules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #4)
For the most part the system goes like this for selecting circulation rules:
1) If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode ...
Thx for explaining Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org