http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-02-08 16:03:14 UTC --- Created attachment 3095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3095 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-06 12:10:04 UTC --- This bug is mentioned in: Fix for Bug 5714, Unescaped ampersands in OPAC facets http://lists.koha-community.org/pipermail/koha-patches/2011-February/013785.... --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-14 06:34:11 UTC --- I am not sure how to test this. I experimented with a subject heading "A & B" but saw no problems in display or search. Can you explain how to reproduce the problem? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3095|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-05-27 12:59:33 UTC --- Created attachment 4275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4275 Revised fix Revised for T:T. In the OPAC the "query_cgi" variable passed to the template outputs a string like this: idx=kw&q=thing The ampersand is unescaped. Adding an "|html" filter to the variable. Also correcting some TT markup which added a new validation error (an unopened <div>). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4275|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> 2011-05-28 23:02:27 UTC --- Created attachment 4289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4289 Signed-off patch Did a search in the OPAC and viewed the source of the page. Before applying the patch a typical URL fragment for one of the facets looked like this: /cgi-bin/koha/opac-search.pl?idx=kw&q=lessig&offset=&expand=su-to#su-to_id After applying the patch they all look like e.g. /cgi-bin/koha/opac-search.pl?idx=kw&q=lessig&offset=&expand=su-to#su-to_id Notice the change from idx=kw&q to kw&q. Signing off! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-06-03 20:44:45 UTC --- Template change, and good test report by Magnus. marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-06-10 17:18:01 UTC --- This patch adds the query_cgi directly to the template, without styling, right above the first facet. I believe this was in there for debugging purposes, and needs to be removed or styled in such as way that it can be suppressed (we've got some libraries reporting that it's unattractive). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5714 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.