[Bug 38607] New: Default CART notice is removing spaces from subtitles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 Bug ID: 38607 Summary: Default CART notice is removing spaces from subtitles Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: Find a record with a subtitle, edit and save to ensure the subtitle field is populated Add it to a cart on the OPAC open the cart and send If your Koha doesn't send emails, just check the message queue: SELECT * FROM message_queue; Notice the subtitle has no spaces The cart template has: [% FOREACH subtitle IN biblio.subtitle.split(" | ") %] Changing to split only on | seems to work: [% FOREACH subtitle IN biblio.subtitle.split("|") %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This seems to be the best fix, need to escape the characters: [% IF ( biblio.subtitle ) %][% FOREACH subtitle IN biblio.subtitle.split('\ \|\ ') %][% subtitle | html %][% END %][% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Default CART notice is |CART notice issues |removing spaces from | |subtitles | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 175095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175095&action=edit Bug 38607: CART notice issues When sending carts, spaces are removed from subtitles and if there is a shelving location but no call number there isn't a space between the shelving location and the item barcode. Test plan: 1. Find an item with a subtitle 2. Make sure the account you're using has an email address 3. Add it to your cart in the OPAC 4. Send the cart to yourself 5. In the staff interface, create and run this report: SELECT * FROM message_queue; 6. Notice the subtitle has no spaces and there isn't a space between the location and the barcode 7. Apply the patch 8. Go to the notice in the staff interface and select "view default notice" 9. Copy the default into your notice and save. 10. Repeat steps 4 & 5 11. Observe that the spacing is now correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #3 from David Nind <david@davidnind.com> --- I've failed QA after testing using KTD: 1. Before the patch, if a record as a " :" at the end of the title (245$a) and a subtitle (245$b): . In the cart: it only lists the main part of the title (with a space then : after it) . The message: doesn't include the subtitle, and doesn't have the : 2. If I removed the " :" from the record, everything matches the behavour described in the bug. 3. After the patch, if a record has a " :" . In the cart: displays correctly . In the message: doesn't include the " :" between the title and subtitle 4. The patch fixes the space between the location and the barcode. Items: - Fairview , General stacks 39999000006094 5. But notice that there is still a space between the library and the comma. I used record this record to test: 146 - The definitive guide to Catalyst : writing extensible, scalable, and maintainable Perl-based Web applications / Kieren Diment and Matt S. Trout ; with Eden Cardim, Jay Kuri, and Jess Robinson. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org