[Bug 8495] New: Javascript error when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Priority: P5 - low Change sponsored?: --- Bug ID: 8495 Assignee: julian.maurice@biblibre.com Summary: Javascript error when creating a new order Severity: normal Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha Steps to reproduce: - syspref AcqCreateItem='ordering' - syspref UniqueItemFields='barcode' (or something else, but not empty) - with Firebug, enable the 'persistent' mode, so you can see the error message even after form is submitted - create a new order, add 1 item, select a budget and click on save. - you should see in firebug an error like this : "Syntax error, unrecognized expression: [value=items.barcode]". This cause the form to be submitted too early in the validation process. Patch is coming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11101&action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11101|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11106&action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 11106 [details] Bug 8495: Fix JS error when creating a new order
bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178)
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
hmmm, we are waiting for a 'non BibLibre' sign-off here, before QA? i will change status to 'needs-signoff' (i hope that is ok?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11106|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11524&action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Created attachment 11524 [details] Bug 8495: Fix JS error when creating a new order
bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178)
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * cf863e0 Bug 8495: Fix JS error when creating a new order koha-tmpl/intranet-tmpl/prog/en/js/additem.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed today -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Ok in master and 3.8.x. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org