[Bug 37148] New: Move the filter bar in Holds to Pull report from the bottom to the top of the table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Bug ID: 37148 Summary: Move the filter bar in Holds to Pull report from the bottom to the top of the table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.auld@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The Holds to Pull report table of results has a filter bar which only appears at the end of each page of results. In systems where there are a lot of libraries/branches, this can mean scrolling a long way to allow the user to filter to show results from their library/branch, or to filter in another way. Possibly related to Bug #35139 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168175&action=edit Bug 37148: Moved filter bar to the top of Holds to Pull report table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cubingguy714@gmail.com --- Comment #2 from Eric Garcia <cubingguy714@gmail.com> --- To Test: 1. Go to Circulation -> Holds to pull 2. Notice filter bar is at the bottom of the table. 3. Apply patch, restart_all 4. See filter bar at the top of the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com --- Comment #3 from Sam Lau <samalau@gmail.com> --- Instead of putting the filters into the same <thead>, I recommend just doing a new <thead></thead> underneath the existing one and then putting the filter code in there. This makes everything less crowded and with the current patch, it's hard to see what you type in for some of the filters, specifically "Pull this many items". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 helm.consortium@nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helm.consortium@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi Status|Needs Signoff |Failed QA --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Looks like the patch breaks the Columns drop down menu of the Hold to pull report. After applying the patch to a sandbox, Columns menu only has the little check marks without the column names. I tried with two PTFS Europe's sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|cubingguy714@gmail.com |jacob.omara@ptfs-europe.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're going to resurrect this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #6 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 170759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170759&action=edit Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we consider doing this to all tables with the filter options? I think they never really make sense at the bottom: when I have so many results I want to filter, I don't want to have to scroll down first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Agreed; it seems silly to have them at the bottom. Let's get this signed-off, and then I can work on a separate omnibus bug for the rest of them? Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jacob.omara@ptfs-europe.com |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do we need to obsolete the first patch here now Jake? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |holds function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #9)
Do we need to obsolete the first patch here now Jake?
Answer: Yes.. the new patch is a fresh patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170759|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170955&action=edit Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as described.. so signing off. However, the commit message format is wrong.. remember to run the QA script against your patches Jake.. it'll highlight that sort of minor error (: instead of - please ;P ) I wonder about generalising as Katrin has asked.. though I can't entirely remember how these bits fit together right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So.. we actually already have the 'add_filters' option available to us in the KohaTable component.. however for some reason it doesn't work as expected for this table. I think this patch is OK as is.. but we could investigate why it doesn't work here if we wanted.. or just not worry and leave it to the ajax tables when that eventually rolls around to this particular case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #14 from Jake Deery <jake.deery@ptfs-europe.com> --- Ah, nicely spotted — you might need to show me where to find those QA scripts and the best options to use :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172279&action=edit Bug 37148: [WIP] use built in table filtering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170955|0 |1 is obsolete| | Attachment #172279|0 |1 is obsolete| | --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172280&action=edit Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I got the built in filters to show, but styling was wrong and no branch dropdown - PQA here - having good instructions on how to add filters would be nice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Yeah, it's an odd case.. I'm not at all sure why the built in filters aren't working nicely in this particular table. I think this is an OK middle ground for now, but I'd love to understand what's going on later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- + [% IF print %] + <script> + $( document ).ready(function() { + window.print(); + window.onafterprint = function () {+ window.close(); + } + setTimeout('window.close()', 1000); // Hack for Chrome < 63 + }); + </script> + [% END #/print %] Why do we have this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #15)
Created attachment 172279 [details] [review] Bug 37148: [WIP] use built in table filtering
What's wrong exactly with this patch? Why is the styling wrong? We cannot add the dropdown in the column filters with KohaTable (columns_settings.inc), only using kohaTable (datatables.js, ie. when using the REST API) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move the filter bar in |Move the filter bar in the |Holds to Pull report from |'holds to pull' report from |the bottom to the top of |the bottom to the top of |the table |the table Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please take a look at Jonathan's comments? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172280|0 |1 is obsolete| | --- Comment #22 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173272&action=edit Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Jake Deery <jake.deery@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #19)
+ [% IF print %] + <script> + $( document ).ready(function() { + window.print(); + window.onafterprint = function () {+ window.close(); + } + setTimeout('window.close()', 1000); // Hack for Chrome < 63 + }); + </script> + [% END #/print %]
Why do we have this?
I don't think we do anymore, actually. I think it is obsolete, so I have removed it. Thanks :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict here in the JS for datatables - please review and rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173272|0 |1 is obsolete| | --- Comment #25 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 174757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174757&action=edit Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #26 from Jake Deery <jake.deery@ptfs-europe.com> --- Rebased :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- This is wrong, it is removed + [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Also, please run the QA script * Commit title does not start with 'Bug XXXXX: ' - 6b0d29d5863 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- The filtering is actually totally broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #29)
The filtering is actually totally broken.
in main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jake.deery@ptfs-europe.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- I will rework this page, on top of bug 36640, and use the regular "add_filters" option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37148 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Moved to bug 38484. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org