[Bug 13793] New: The installer does not output the result of the update using Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Bug ID: 13793 Summary: The installer does not output the result of the update using Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Under Plack, the installer does not output the result of the update. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13791 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36454&action=edit Bug 13793: Make the installer output the result of the updates under Plack Test plan: 0/ Start plack for intranet 1/ Create a new entry in updatedatabase.pl, something like: $DBversion = "3.19.00.013"; if(CheckVersion($DBversion)) { print "Upgrade to $DBversion done (Bug test plack - This is a est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is anoter est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is a third est)\n"; warn "this is an error"; } and modify the kohaversion.pl accordingly. You can also warn something to simulate an error. 2/ Go on the mainpage (or wherever you want), you should be redirected to the installer 3/ Notice that the output of the updatedatabase is displayed on the screen. 4/ Confirm that new files have been created in your Koha log directory (check the logdir entry in your koha conf file). 5/ Confirm that the output is still displayed without Plack. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36454|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 36546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36546&action=edit Bug 13793: Make the installer output the result of the updates under Plack Test plan: 0/ Start plack for intranet 1/ Create a new entry in updatedatabase.pl, something like: $DBversion = "3.19.00.013"; if(CheckVersion($DBversion)) { print "Upgrade to $DBversion done (Bug test plack - This is a est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is anoter est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is a third est)\n"; warn "this is an error"; } and modify the kohaversion.pl accordingly. You can also warn something to simulate an error. 2/ Go on the mainpage (or wherever you want), you should be redirected to the installer 3/ Notice that the output of the updatedatabase is displayed on the screen. 4/ Confirm that new files have been created in your Koha log directory (check the logdir entry in your koha conf file). 5/ Confirm that the output is still displayed without Plack. Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36546|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36657&action=edit Bug 13793: Make the installer output the result of the updates under Plack Test plan: 0/ Start plack for intranet 1/ Create a new entry in updatedatabase.pl, something like: $DBversion = "3.19.00.013"; if(CheckVersion($DBversion)) { print "Upgrade to $DBversion done (Bug test plack - This is a est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is anoter est)\n"; print "Upgrade to $DBversion done (Bug test plack - This is a third est)\n"; warn "this is an error"; } and modify the kohaversion.pl accordingly. You can also warn something to simulate an error. 2/ Go on the mainpage (or wherever you want), you should be redirected to the installer 3/ Notice that the output of the updatedatabase is displayed on the screen. 4/ Confirm that new files have been created in your Koha log directory (check the logdir entry in your koha conf file). 5/ Confirm that the output is still displayed without Plack. Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13791 Depends on|13791 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With this patch I can't run the web installer in my dev installation. Following error is displayed: Cannot open log file /home/katrin/koha-dev/var/log/updatedatabase_2015-03-15T21:59:53.log: No such file or directory at /home/katrin/kohaclone/installer/install.pl line 332. After reverting the patch the update process is completed normally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Katrin, i tested both with and without plack on a regular dev install before pushing. Please share some details about your directory structure and permission. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sure, it might be my installation, but I thought it would be better to have someone check. This is a standard dev installation. The logs are being written to /home/katrin/koha-dev/var/log The files within the directory currently are: -rw-r--r-- 1 root root 436429 Mär 15 23:11 koha-error_log -rw-r--r-- 1 root root 98095 Mär 6 14:55 koha-opac-error_log -rw-r--r-- 1 katrin katrin 3657 Mär 15 02:46 koha-zebradaemon.err -rw-r--r-- 1 katrin katrin 13428 Mär 15 23:19 koha-zebradaemon-output.log I am not sure why there is a mix of root/katrin. Writing to the existing files seems to work alright. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And permissions on the directory itself: drwxr-xr-x 2 katrin katrin 4096 Mär 15 23:45 log -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Cannot open log file /usr/share/kohadev/testclone/var/log/updatedatabase_2015-03-16T09:42:31.log: No such file or directory at /usr/share/koha/testclone/installer/install.pl line 332. If I update via the webinstaller, the apache user has no permission to write a new log file in that directory. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Mar 19 09:40:31 kernel: type=1400 audit(): avc: denied { write } for pid=14194 comm="sh" name="log" dev="md2" ino=11150563 scontext=system_u:system_r:httpd_sys_script_t:s0 tcontext=unconfined_u:object_r:httpd_log_t:s0 tclass=dir If I set the permission of this log folder to 777 (which I do not like!), I stumble over my next security measure: SELinux. That's good :) I can go further and add exceptions for that too of course. But I think we are working in the wrong direction. Can we REVERT this patch please? The patch is meant for Plack users. Please write it so that non-Plack users are not affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13876 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- See bug 13876 for a fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13876 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org