[Bug 24217] New: use Modern::Perl for modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Bug ID: 24217 Summary: use Modern::Perl for modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org This is not done yet! We need that for modules (at least) ASAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96202&action=edit Bug 24217: use Modern::Perl for modules We absolutely need that for modules. Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- RMaints, I do not think you should backport this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think we missed a few ;) I used `grep -IRiL "Modern::Perl" **/*.pm` to check and came up with this list after your patch C4/AuthoritiesMarc.pm C4/Auth.pm C4/Auth_with_cas.pm C4/Barcodes.pm C4/Bookseller.pm C4/Boolean.pm C4/Breeding.pm C4/Calendar.pm C4/Charset.pm C4/ClassSortRoutine.pm C4/ClassSource.pm C4/Creators.pm C4/Debug.pm C4/HoldsQueue.pm C4/HTML5Media.pm C4/Images.pm C4/ImportBatch.pm C4/ImportExportFramework.pm C4/ItemCirculationAlertPreference.pm C4/Labels.pm C4/Languages.pm C4/Linker.pm C4/Log.pm C4/Message.pm C4/Patroncards.pm C4/Scrubber.pm C4/Service.pm C4/ShelfBrowser.pm C4/SMS.pm C4/Stats.pm C4/Tags.pm C4/Templates.pm C4/TmplToken.pm C4/TTParser.pm Koha/Cache.pm Koha/Calendar.pm Koha/Edifact.pm Koha/EDI.pm Koha/Schema.pm Koha/SuggestionEngine.pm OpenILS/QueryParser.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96202|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96204&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use Modern::Perl for |use strict for all modules |modules | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96205&action=edit Bug 24217: use Modern::Perl for modules We absolutely need that for modules. Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96204|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96206&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Agreed, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24218 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24218 [Bug 24218] We should consistently `use Modern::Perl` in all modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96206|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96312&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24361 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See bug 24361 for follow-ups. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 [Bug 24361] Fix warnings (or failing tests) from bug 24217 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24365 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It broke the translator script, see bug 24365. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 [Bug 24367] With strict enabled, Search.t is too verbose -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529 [Bug 24529] Uninitialised value warnings in C4::Reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 [Bug 24595] Warnings displayed by Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305 [Bug 25305] Double UTF-8 encoding on translation files -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org