[Bug 7333] New: Cleaning up tests to use sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Bug #: 7333 Summary: Cleaning up tests to use sample data Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite AssignedTo: gmcharlt@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: ian.walls@bywatersolutions.com Some of the tests in t/db_dependent expect data in the test database that isn't available in the sample data. This bug will be the home to the fixes for that issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-12-07 22:37:39 UTC --- Created attachment 6649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6649 Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data To test: Create a fresh koha db with all of the sample data (if you have one that has the sample branches in it, that will work too) run the test: prove t/db_dependent/Members.t All subtests should complete. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED CC| |wizzyrea@gmail.com Patch Status|--- |Needs Signoff --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-12-07 23:44:20 UTC --- t/db_dependent/Serials.t requires at least one subscription in your test database to clear correctly. Plan: make the test create a subscription and remove it as part of the tests. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 00:33:09 UTC --- t/db_dependent/VirtualShelves.t requires at least 10x biblio records to pass tests. Not sure how to go about this one - make the test add 10x bibs or create a new sample data category for "required data for unit testing." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 00:43:30 UTC --- Created attachment 6652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6652 Bug 7333 - interim test db that will allow all db_dependent tests to pass -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6652|1 |0 is patch| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6652|text/plain |application/x-gzip mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 00:46:29 UTC --- Comment on attachment 6652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6652 Bug 7333 - interim test db that will allow all db_dependent tests to pass hm I'm not sure I did that right. Maybe I"ll need to do it manually instead of with git bz. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6652|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |wizzyrea@gmail.com --- Comment #6 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 00:53:27 UTC --- Created attachment 6653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6653 Testing Database In the interim, this db should be usable to pass all db_dependent tests. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6649|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:34:22 UTC --- Created attachment 6734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6734 [SIGNED-OFF] Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data To test: Create a fresh koha db with all of the sample data (if you have one that has the sample branches in it, that will work too) run the test: prove t/db_dependent/Members.t All subtests should complete. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests complete successfully with my database created from sample data and with the database provided on the bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-12-15 16:29:12 UTC --- Created attachment 6815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6815 Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N. for helping figure out that it was because there were no French stopwords in the DB that the test was failing. Patch changes the French string (with French stopwords) to an English string with English stopwords, as only English stopwords are installed in the default data. This patch will allow Search.t to run on the database attached to this bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 17:15:08 UTC --- patch [SIGNED-OFF] Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data pushed QA comment : fixes the problem (i made a fresh install of sample database) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6734|0 |1 is obsolete| | Attachment #6815|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-18 07:26:24 UTC --- Created attachment 6848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6848 Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N. for helping figure out that it was because there were no French stopwords in the DB that the test was failing. Patch changes the French string (with French stopwords) to an English string with English stopwords, as only English stopwords are installed in the default data. This patch will allow Search.t to run on the database attached to this bug. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Signed Off |Passed QA QAContact|ian.walls@bywatersolutions. |m.de.rooy@rijksmuseum.nl |com | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-22 08:02:52 UTC --- Stumbled across this one accidentally too this morning and was preparing to send this patch line: Les chaussettes de l'archiduchesse with an English one to make this test not only function in a French environment But yours will probably be received without hurting less feelings ;) Updating patch status.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7333 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 17:41:36 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org