[Bug 27519] New: Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Bug ID: 27519 Summary: Normalize Show/Don't show vs Display/Don't display in system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is something I came across when translating Koha. Some system preferences use Display/Don't display as their choices and others use Show/Don't show. I propose to normalize the terms, i.e. choose one and stick with it (with the amount in each, I would choose to keep Show/Don't show). Show/Don't show - AdlibrisCoversEnabled - AmazonCoverImages - DisplayClearScreenButton - displayFacetCount - DisplayOPACiconsXSLT - EnhancedMessagingPreferencesOPAC - ExportCircHistory - FRBRizeEditions - hidelostitems - HidePatronName - intranetbookbag - IntranetCatalogSearchPulldown - LibraryThingForLibrariesEnabled - numSearchResultsDropdown - OPACAmazonCoverImages - OpacCloud - OPACItemsResultsDisplay - OpacKohaUrl - OPACnumSearchResultsDropdown - OPACpatronimages - OPACShowCheckoutName - OPACShowMusicalInscripts - OpacShowRecentComments - OpacSuggestionManagedBy - OPACFRBRizeEditions - OpacMaintenance - OPACUserSummary - OpenLibrarySearch - OPACShelfBrowser - OPACShowUnusedAuthorities - OPACViewOthersSuggestions - SelfCheckReceiptPrompt - ShowAllCheckins - showLastPatron - ShowPatronImageInWebBasedSelfCheck - SyndeticsAuthorNotes - SyndeticsAwards - SyndeticsCoverImages - SyndeticsEditions - SyndeticsExcerpt - SyndeticsReviews - SyndeticsSeries - SyndeticsSummary - SyndeticsTOC - UseWYSIWYGinSystemPreferences Display/Don't display - AcquisitionDetails - advancedMARCeditor - AuthDisplayHierarchy - BiblioItemtypeInfo - CustomCoverImages - EasyAnalyticalRecords - hide_marc - LocalCoverImages - OPACAcquisitionDetails - OPACCustomCoverImages - OPACLocalCoverImages - OpacNewsLibrarySelect - OPACPopupAuthorsSearch - SpineLabelShowPrintOnBibDetails While we're at it, I would also change the following : - noItemTypeImages: Yes/No - OpacNoItemTypeImages: Yes/No - ShowReviewerPhoto: Show/Hide - PatronSelfRegistrationPrefillForm: display and prefill/don't display and prefill -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- No comment? We'll use display/not display accross the board. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #2 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 135144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135144&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin@inlibro.com |shi-yao.wang@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135144|0 |1 is obsolete| | --- Comment #3 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 135145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135145&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135145|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135175&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I love consistency for terminology, so this is great! I have two suggestions to move the "Show/Don't show" options to the start of the system preference text, rather than at the end, to be as consistent as possible with how it is used elsewhere: - noItemTypeImages: . Updated text: Show itemtype icons in the staff interface: Show/Don't show . Change to: Show/Don't show itemtype icons in the staff interface. - OpacNoItemTypeImages: . Updated text: Show itemtype icons in the OPAC: Show/Don't show . Change to: Show/Don't show itemtype icons in the OPAC. I'll also add to the terminology list: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135175|0 |1 is obsolete| | --- Comment #6 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 135203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135203&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #7 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to David Nind from comment #5)
I love consistency for terminology, so this is great!
I have two suggestions to move the "Show/Don't show" options to the start of the system preference text, rather than at the end, to be as consistent as possible with how it is used elsewhere:
- noItemTypeImages: . Updated text: Show itemtype icons in the staff interface: Show/Don't show . Change to: Show/Don't show itemtype icons in the staff interface.
- OpacNoItemTypeImages: . Updated text: Show itemtype icons in the OPAC: Show/Don't show . Change to: Show/Don't show itemtype icons in the OPAC.
I'll also add to the terminology list: https://wiki.koha-community.org/wiki/Terminology
Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Shi Yao Wang from comment #7)
(In reply to David Nind from comment #5)
I love consistency for terminology, so this is great!
I have two suggestions to move the "Show/Don't show" options to the start of the system preference text, rather than at the end, to be as consistent as possible with how it is used elsewhere:
- noItemTypeImages: . Updated text: Show itemtype icons in the staff interface: Show/Don't show . Change to: Show/Don't show itemtype icons in the staff interface.
- OpacNoItemTypeImages: . Updated text: Show itemtype icons in the OPAC: Show/Don't show . Change to: Show/Don't show itemtype icons in the OPAC.
I'll also add to the terminology list: https://wiki.koha-community.org/wiki/Terminology
Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages.
Hi Shi Yao. Thanks for updating. However, I think I may have confused things! I meant having the dropdown list with the choice at the front, rather than at the end of the sentence - eliminating the "double" show. For example: - For OpacNoItemTypeImages it should read as: [Show/Don't show] itemtype icons in the OPAC. - Rather than: Show/Don't show itemtype icons in the OPAC: [Show/Don't show] Hope that makes sense! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135203|0 |1 is obsolete| | --- Comment #9 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 135215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135215&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135215|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 135217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135217&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Shi Yao for updating! I've added my sign off as well, to show the QA I've checked the change0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #12 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- No problem David. Thanks for the sign offs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135217|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135478&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement replaces release notes| |"Display/Don't display" | |with "Show/Don't show" for | |several system preferences | |to improve terminology | |consistency and make | |translation easier. A few | |preferences were also | |updated where "Yes/No" and | |"Show/Hide" were used. Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/582 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work on the docs too Caroline.. merging now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual |Manual-updated CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org