[Bug 10565] New: Add a "Patron List" feature for storing and manipulating collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Bug ID: 10565 Summary: Add a "Patron List" feature for storing and manipulating collections of patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries would like to create lists of patrons for later manipulation. This will involve create a "Patron List" system similar in some ways to the existing Lists feature for records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8798 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19726&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from the "More" pulldown on the main menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19726|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19727&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19727|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19728&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Unit tests will be forthcoming, qa fyi ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- A template file seems to be missing: patron_lists/list.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19728|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19732&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19732|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19733&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Good catch, fixed! (In reply to Owen Leonard from comment #5)
A template file seems to be missing: patron_lists/list.tt
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19733|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19734&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- After you create a new list, it would be nice if it redirected you to the page for adding patrons to that list. That's how it works with book lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz@catalyst.net.nz --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- I like this a lot. Like, a LOT. As in, I squeed when I was playing with it. However, there is something really strange about the hover state of the buttons - see http://img844.imageshack.us/img844/6169/iq7r.png That's Firefox 22 on Ubuntu Precise. Also, the unit test seems to fail: devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 t/db_dependent/PatronLists.t .. 5/9 # Failed test 'AddPatronsToList works for cardnumbers' # at t/db_dependent/PatronLists.t line 38. # Looks like you failed 1 test of 9. t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.70 cusr 0.04 csys = 0.76 CPU) Result: FAIL Functional tests pass though... and I mean it when I say this is really fantastic. People will throw confetti. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19734|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19757&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19759&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup - Fix DBIx::Class error Fixes this error: DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19757|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19761&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19759|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19762&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup - Fix DBIx::Class error Fixes this error: DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Liz Rea from comment #11)
I like this a lot. Like, a LOT. As in, I squeed when I was playing with it. However, there is something really strange about the hover state of the buttons - see http://img844.imageshack.us/img844/6169/iq7r.png
That's Firefox 22 on Ubuntu Precise.
It looks like the bootstrap css isn't playing well with Koha's css somewhere. I have it fixed in this new edition of the patch.
Also, the unit test seems to fail:
devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 t/db_dependent/PatronLists.t .. 5/9 # Failed test 'AddPatronsToList works for cardnumbers' # at t/db_dependent/PatronLists.t line 38. # Looks like you failed 1 test of 9. t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests
Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.70 cusr 0.04 csys = 0.76 CPU) Result: FAIL
That's odd, I've run the test with multiple databases without an issue. Please try again with this followup patch.
Functional tests pass though... and I mean it when I say this is really fantastic. People will throw confetti.
Excellent! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Done! (In reply to Owen Leonard from comment #10)
After you create a new list, it would be nice if it redirected you to the page for adding patrons to that list. That's how it works with book lists.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10612 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19770&action=edit Bug 10565 [Follow-up] Add a "Patron List" feature for storing and manipulating collections of patrons This patch makes the following changes: On the list add/edit page: - Improvements to breadcrumbs and titles on the add/edit page. - Removal of custom validation JavaScript in favor of built-in validation plugin. On the list view page: - Corrected title on list page: Showing list name instead of "New list" - Added "select all" and "clear all" to a toolbar like on the biblio list page. Moved the "remove selected" button to this toolbar like it is on the biblio list page. - Added more standard DataTables configuration with default sort, correctly ignored columns, and pager count options. - Display patron names as "surname, firstname." - Improve JavaScript for removing entries from the list of patrons to add (to avoid "javascript:" pseudo-protocol). - Move "add patrons" controls so that they are only shown after patrons have been added. - Add toolbar to patron list view page with button for "Edit list" and "Batch modify." The "Batch modify" button takes you directly to a batch modification operation on your list. - Added zipcode to displayed information. - Added message to be displayed when there are no items on the list (instead of showing empty table). On the list of lists page: - Added more standard DataTables configuration with default sort, correctly ignored columns, and pager count options. - Wrapped "new list" button in standard toolbar div. - Show message instead of empty table if there are no lists. - Style in-table buttons with "btn-mini" for more compact look. On scripts: - Changed "authnotrequired" from 1 to 0, added 'borrowers' permission requirement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- By the way, I removed the Bootstrap styling from the primary submit buttons because I'd rather change that standard interface element in a more deliberate way. I think if we want to start using different styling on submit buttons we should choose a style which is at least somewhat different than toolbar buttons, perhaps a different color of a more subtle style difference. On the other hand, I think Bootstrap's "btn-mini" style is good for controls inside tables, and is something we should start expanding our use of. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19761|0 |1 is obsolete| | Attachment #19762|0 |1 is obsolete| | Attachment #19770|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20511&action=edit [SIGNED-OFf] Bug 10656: add regression test This patch adds regression tests to verify the sort order when fetching authorised values in either staff or OPAC mode. This patch also wraps the Koha.t tests in a transaction, and better handles skipping tests if Test::Deep is not installed. To test: [1] Verify that prove -v t/db_dependent/Koha.t passes Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass with all patches applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19761|1 |0 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19762|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19770|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry... typoed the bug number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #22 from Liz Rea <liz@catalyst.net.nz> --- Question, for fields like "Library" - Under what condition would you ever want to delete that field entirely? Is it possibly dangerous to allow? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #23 from Liz Rea <liz@catalyst.net.nz> --- Also, after a batch modification it would probably be best to show all of the fields in the result table, and if not that, then at least show the columns that were modified. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #24 from Liz Rea <liz@catalyst.net.nz> --- er just realised that the last two comments really have nothing to do with this. Sorry about that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #25 from Liz Rea <liz@catalyst.net.nz> --- A few legitimate questions - What happens if the borrower you are looking for to add to a list has a name that is fewer than 3 characters? It seems one cannot submit a search manually without the autocomplete. I'm not sure I'd fail it for this, but maybe worth thinking about. It seems also that you cannot add borrowers to a list that do not have a cardnumber. Feature, or bug? Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Liz Rea <liz@catalyst.net.nz> --- I also see that you *can* add borrowers with no cardnumber to a borrower list if you tick the box next to their name in a result list and -> add to list. patron_lists/list.pl?patron_list_id=2 < from here you cannot add borrowers with no cardnumber, so I think I've come to think this is a bug and not a feature. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20721&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 3 * Borrower search works for names with < 3 characters * Borrowers without cardnumbers can now be added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Liz, all your comments and concerns are valid. Thanks! I believe this latest followup should address all those issues. Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Liz Rea <liz@catalyst.net.nz> --- One weirdness: http://img716.imageshack.us/img716/7357/rgya.png The add patron button looks a bit strange here. I wonder if you could just go with the word "Add" ? Nice to have, but not required to have (future maybe?) - add a borrower to a list from their detail or circulation screen (in the more menu perhaps?) Add a link or button to the list interface from the borrower result screen? Add a link or button to delete a list from a displayed list - (patron_lists/list.pl?patron_list_id=10 for example) The ability to export the contents of a patron list as CSV. Even cooler if you could choose which fields to export - I'm thinking of a method by which librarians could, without using saved reports, get a list of borrowers to email, for example. (I know! I know. Scope creep. Just writing it down so the idea doesn't get lost. :)) Functionally this works great - I'm still having trouble with the tests though: devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_devlibrary`.`patron_lists`, CONSTRAINT `patron_lists_ibfk_1` FOREIGN KEY (`owner`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO patron_lists ( name, owner) VALUES ( ?, ? )" with ParamValues: 0='Test List 1', 1=1] at Koha/List/Patron.pm line 121 # Looks like you planned 9 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/PatronLists.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 7/9 subtests Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 2. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.52 cusr 0.02 csys = 0.57 CPU) Result: FAIL Of note, and possibly extremely relevant, is that my failure results came from an *upgraded* database, and not a fresh one. All tests pass on a fresh database with only the sample data. I'm putting this in failed qa only because I'd like an answer about the upgraded DB tests - assuming that is all ok, I'm happy to sign off on this as-is. Thanks for your continued work, Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20768&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 4 - Don't assume borrowernumber 1 exists in unit test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Liz, I think the problem with the unit test is that I'm assuming there is a borrower with a borrowernumber of 1 that is the inital Koha Admin account created during installation. Is this an improper assumption? I'm guessing it is. I've attached another followup to remedy the situation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nora Blake <nblake@masslibsystem.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nblake@masslibsystem.org --- Comment #32 from Nora Blake <nblake@masslibsystem.org> --- I am extremely happy with this and would like to sign off on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19761|0 |1 is obsolete| | CC| |melissa@bywatersolutions.co | |m --- Comment #33 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21084&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19762|0 |1 is obsolete| | --- Comment #34 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21086&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup - Fix DBIx::Class error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19770|0 |1 is obsolete| | --- Comment #35 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21087&action=edit Bug 10565 [Follow-up] Add a "Patron List" feature for storing and manipulating collections of patrons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20721|0 |1 is obsolete| | --- Comment #36 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21088&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20768|0 |1 is obsolete| | --- Comment #37 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 21089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21089&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup 4 - Don't assume borrowernumber 1 exists in unit test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21084|0 |1 is patch| | Attachment #21084|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21086|0 |1 is patch| | Attachment #21086|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21087|0 |1 is patch| | Attachment #21087|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21088|0 |1 is patch| | Attachment #21088|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21089|0 |1 is patch| | Attachment #21089|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Pushed to Master --- Comment #38 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with follow-ups, including one that adds a new tools permission for the feature. Note that I did not include your first three follow-ups as they ended up conflicting with the fix for 10636. Thanks, Kyle! I will add, however, that this made it in by the skin of its teeth, and primarily because it exercises DBIx::Class support. In particular, it was rather careless that the patch as submitted did not require staff authentication. This is a BIG deal -- even if the feature were suitable for all staff users (which is debatable for technical services staff) -- it is obviously not suitable for anybody who happens to be good add guessing URL patterns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #39 from Nicole C. Engard <nengard@gmail.com> --- Just did a fetch and get this error when trying to open the new tool: Base class package "DBIx::Class::Schema" is empty. (Perhaps you need to 'use' the module which defines that package first, or make that module available in @INC (@INC contains: /home/nengard/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .). at /home/nengard/kohaclone/Koha/Schema.pm line 10 BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Schema.pm line 10. Compilation failed in require at /home/nengard/kohaclone/Koha/Database.pm line 38. BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Database.pm line 38. Compilation failed in require at /home/nengard/kohaclone/Koha/List/Patron.pm line 32. BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/List/Patron.pm line 32. Compilation failed in require at /home/nengard/kohaclone/patron_lists/lists.pl line 26. BEGIN failed--compilation aborted at /home/nengard/kohaclone/patron_lists/lists.pl line 26. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #40 from Nicole C. Engard <nengard@gmail.com> --- nevermind - fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9811 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #41 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Why is this feature not accessible from the HTML header "More" -> "Lists" ? I found a character encoding issue when displaying the Patrons "circ notes" inside the Patron list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I'd say it's not a new module, but an additional feature set for the patrons module, so it wouldn't go under more, but it's accessible from the tools page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11941 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11942 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #43 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- It is a list, the header has "more" -> "lists" implying more lists :) imho all kind of lists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #44 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Olli-Antti Kivilahti from comment #43)
It is a list, the header has "more" -> "lists" implying more lists :) imho all kind of lists
Agreed that it could be confusing to make the distinction between lists (of books, sometimes referred to as virtual shelves in Koha) and patron lists (brand new), please note that the patron lists are staff-based, while lists are opac-based (with support in staff). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11906 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #45 from Robin Sheat <robin@catalyst.net.nz> --- Too late to do much about it now, but this doesn't follow: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL14:_Exports and arguably the next one too. We should try to avoid littering the namespace with default exports. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11857 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10612 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 [Bug 10612] Add ability to delete patrons with batch patron deletion tool -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org