[Bug 20970] New: Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Bug ID: 20970 Summary: Reformat basket information on acquisitions basket page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 76213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76213&action=edit GIF showing new forms interaction I'd like to propose a couple of minor changes to the way information and forms are displayed on the acquisitions basket view page: - Hide form controls until the user clicks a link - Move some information into the second column to make it a little more balanced. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76214&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This looks way better than the grey buttons. I did have a couple of problems though 1) I had trouble applying the patch, I had to add manually basket.tt and then resume applying. 2) Once the patch is applied, if I click on "Add user", nothing happens, but if I remove the patch, and click on "Add user", the pop-up appears. 3) Same thing if I click on "Set library" or "Change basket group" And my other comment is purely personal, I love the way it looks, but it adds one click. To change a basket group, for example, you have to click on "Change basket group", then choose the basket group in the drop down, and save (4 clicks). Whereas now, you just choose the basket group in the drop down and save (3 clicks). It's not the end of the world, and I can absolutely live with one click more, but I just wanted to throw it out there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76214|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77498&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Thanks for testing Caroline. I proposed this change because I think the benefit of a compact and (I hope) more readable display outweighs the downside of an extra click. I've rebased the patch. Can you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The patch applies fine now. Everything works as advertised. That might be beyond your remodeling changes, but maybe we could ditch the "Save changes" button when adding/deleting users? It would save a click (hehe!), and I don't find it super intuitive to have to save once the user appears on the page. When deleting a user, I get that you need a confirmation so that people don't delete users by accident, but even then, I don't find "Save changes" intuitive. And also, if I make a change without saving, and leave the page, there is no warning that I'm leaving unsaved changes (like in the system preferences pages, for example). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77521&action=edit Bug 20970: (follow-up) Reformat basket information on acquisitions basket page This patch adds auto-submit to the branch and basket group selection forms. To test, apply the patch and view a basket in acquisitions. Test the process of changing the managing library and basket group. In both cases, selecting an choice from the dropdown should automatically submit the form. Test as a user with and without permission to manage basket groups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #5)
The patch applies fine now. Everything works as advertised.
That might be beyond your remodeling changes, but maybe we could ditch the "Save changes" button when adding/deleting users?
Good idea! I was able to make it so for the managing library and basket group selection. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77498|0 |1 is obsolete| | Attachment #77521|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79172&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- When IndependentBranches in on, it's not possible to choose the only available site for 'managing library' : the page never reload. Works fine for 'users' and 'basket group'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79172|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80354&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80354|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 80954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80954&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80954|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81028&action=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81029&action=edit Bug 20970: Add preventDefault to avoid trailing # to be added to the url Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org