[Bug 21947] New: Filtering order generates html in notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Bug ID: 21947 Summary: Filtering order generates html in notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org Bug 13618 added a | html to line 717 of opac-details.tt but this generates strange <br> output in the 'Title notes' tab: this<br /> <hr><br /> <br /> is<br /> <hr><br /> <br /> a<br /> <hr><br /> <br /> test from blank lines entered into a 500$a field --- BEGIN --- this <hr> is <hr> a <hr> test --- END --- While HTML (<hr>) should not be in a note, this is used as sample data to also check the blank line to <br>-ish tags, as shown above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13618 Assignee|oleonard@myacpl.org |mtompset@hotmail.com Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 82850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82850&action=edit Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Now if you have a 500$a of: --- BEGIN --- this is a test --- END --- you should see --- BEGIN --- this is a test --- END --- at the start of the Title notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about other occurrences of `git grep "FILTER html_line_break | html"`? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 82857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82857&action=edit Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
What about other occurrences of `git grep "FILTER html_line_break | html"`?
I've attached a patch which should address them all. However, given that I never knew how to trigger them. A test plan is left as an exercise for the reader. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #0)
While HTML (<hr>) should not be in a note, ...
It should be noted that David Cook corrected this poor assumption by pointing out 887: https://www.loc.gov/marc/bibliographic/bd887.html But this patch doesn't touch anything 887-wise, as far as I know. However, it would be a good thing to check for in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82850|0 |1 is obsolete| | Attachment #82857|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82861&action=edit Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82862&action=edit Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13618 | Depends on| |13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82861|0 |1 is obsolete| | Attachment #82862|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82921&action=edit Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82922&action=edit Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- depends on 13618, not backporting to 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23412 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org