[Bug 29825] New: Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Bug ID: 29825 Summary: Preview of authority record on edit mode as MARC formatted view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: gveranis@dataly.gr QA Contact: testopia@bugs.koha-community.org While a librarian is cataloguing an authority record by using the framework cannot check the full view of the record in MARC structure way before saving. That patch will add a new action on edit mode in order to show on a new window a preview of MARC record that will be saved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- George is this something you're working on? If so please assign it to yourself and mark the bug ASSIGNED. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #2 from George Veranis <gveranis@dataly.gr> --- Yes you are right, I just did that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #3 from George Veranis <gveranis@dataly.gr> --- Created attachment 140063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140063&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Template process failed: file error - modals/edit_authority_preview.inc: not found at /kohadevbox/koha/C4/Templates.pm line 127 Looks like you may have forgotten to 'git add' the new include file? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140063|0 |1 is obsolete| | --- Comment #5 from George Veranis <gveranis@dataly.gr> --- Created attachment 140115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140115&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140115|0 |1 is obsolete| | --- Comment #6 from George Veranis <gveranis@dataly.gr> --- Created attachment 140180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140180&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #7 from George Veranis <gveranis@dataly.gr> --- Created attachment 140181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140181&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #8 from George Veranis <gveranis@dataly.gr> --- (In reply to Owen Leonard from comment #4)
Template process failed: file error - modals/edit_authority_preview.inc: not found at /kohadevbox/koha/C4/Templates.pm line 127
Looks like you may have forgotten to 'git add' the new include file?
I think now I did in right way thanks to Andreas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140180|0 |1 is obsolete| | Attachment #140181|0 |1 is obsolete| | --- Comment #9 from George Veranis <gveranis@dataly.gr> --- Created attachment 140182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140182&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #10 from George Veranis <gveranis@dataly.gr> --- Created attachment 140183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140183&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #11 from George Veranis <gveranis@dataly.gr> --- Created attachment 140184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140184&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140182|0 |1 is obsolete| | Attachment #140183|0 |1 is obsolete| | Attachment #140184|0 |1 is obsolete| | --- Comment #12 from George Veranis <gveranis@dataly.gr> --- Created attachment 140185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140185&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #13 from George Veranis <gveranis@dataly.gr> --- Created attachment 140186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140186&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view A new file for modal view of result added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #14 from George Veranis <gveranis@dataly.gr> --- (In reply to Owen Leonard from comment #4)
Template process failed: file error - modals/edit_authority_preview.inc: not found at /kohadevbox/koha/C4/Templates.pm line 127
Looks like you may have forgotten to 'git add' the new include file?
Ok now it looks right, sorry for multiple tries but now you can test it in a normal way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |e.betemps@gmail.com --- Comment #15 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, after applying the patch : - the Edit option is in the 'Action' drop down menu - when I click on this option, the record is displayed but the screen keeps on loading and, even if I see the 'Marc preview' button on the toolbar, I can't do anything (before applying the patch, the 'MARC preview' option in the 'Actions' drop down menu display a pop up which is blank) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140185|0 |1 is obsolete| | Attachment #140186|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152915&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152916&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view A new file for modal view of result added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152917&action=edit Bug 29825: (follow-up) Some style fixes and modal correction This patch makes a few coding style changes to the new JavaScript and updates the Bootstrap modal markup to be in line with current standards. The previous patches lacked a trigger for the preview modal, so I added that. Since the content of the modal uses spaces for formatting I added monospace formatting to the modal body. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- I was curious about this so I thought I'd rebase it and make a few minor corrections just to get it back in play. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #20 from Phil Ringnalda <phil@chetcolibrary.org> --- Using two spaces between the subfield label and the subfield value is jarring. One space isn't entirely shocking, detail.pl does that, or given that this looks more like the advanced bib editor than detail.pl no spaces but some padding or whatever that uses to get a little separation without a whole space wouldn't be shocking to advanced editor users, but two spaces looks like I accidentally started every field with a leading space. It would also be vastly more useful (and probably more accessible) if it copied over the title attributes from tagnum and subfieldcode and used them as titles in the preview. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #21 from Phil Ringnalda <phil@chetcolibrary.org> --- But when I went looking for our house style for displaying MARC, I see that we use either nothing or a leading _ or ‡ or a trailing {space}/ as a subfield delimiter, that we either make the subfield code bold or do not, and that we either follow it with a space or do not, and that we either put each subfield on a new line or do not. _aTitle and <strong>_a</strong> Title are even just two views from the same script. Maybe our house style is "every MARC display must look different than any other MARC display" :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152915|0 |1 is obsolete| | Attachment #152916|0 |1 is obsolete| | --- Comment #22 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 153078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153078&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #23 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 153079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153079&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view A new file for modal view of result added. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152917|0 |1 is obsolete| | --- Comment #24 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 153080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153080&action=edit Bug 29825: (follow-up) Some style fixes and modal correction This patch makes a few coding style changes to the new JavaScript and updates the Bootstrap modal markup to be in line with current standards. The previous patches lacked a trigger for the preview modal, so I added that. Since the content of the modal uses spaces for formatting I added monospace formatting to the modal body. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please fix commit names ! First two patches have the same name, different contents. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #26 from Phil Ringnalda <phil@chetcolibrary.org> --- The commit name for the second would have been "Bug 29825: Oops, I forgot to 'git add'" so really rather than fixing it, the first two should just be squashed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Ok great, so you can do it, attach and the ticket will sort itself out automatically I think (will only keep your two patches after the squash). Otherwise it will need to be manually obsoleted ("Details" link next to the patch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153078|0 |1 is obsolete| | Attachment #153079|0 |1 is obsolete| | Attachment #153080|0 |1 is obsolete| | --- Comment #28 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 159200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159200&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #29 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 159201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159201&action=edit Bug 29825: (follow-up) Some style fixes and modal correction This patch makes a few coding style changes to the new JavaScript and updates the Bootstrap modal markup to be in line with current standards. The previous patches lacked a trigger for the preview modal, so I added that. Since the content of the modal uses spaces for formatting I added monospace formatting to the modal body. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159200|0 |1 is obsolete| | Attachment #159201|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164126&action=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164127&action=edit Bug 29825: (follow-up) Some style fixes and modal correction This patch makes a few coding style changes to the new JavaScript and updates the Bootstrap modal markup to be in line with current standards. The previous patches lacked a trigger for the preview modal, so I added that. Since the content of the modal uses spaces for formatting I added monospace formatting to the modal body. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch set contains some small issues I have fixed in a follow-up. Please keep in mind for later submissions :) This string in JavaScript is not translatable. _() must be used: + var content = "<h3>Authority #: [% authid | html %]</h3><hr>"; Also capitalization should be "MARC preview" according to our guidelines here: + <a class="btn btn-default" id="preview" href="#"><i class="fa fa-eye"></i> MARC Preview</a> One general question: With this we have a different style of preview from the result list of the authortiy search and the detail page. Should they be labelled differently? Should they be styled the same? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #32)
With this we have a different style of preview from the result list of the authority search and the detail page.
I think the preview from the authority search result page should be replaced with this version. It's more consistent with the way we show MARC previews from the bibliographic detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36711 [Bug 36711] Replace "MARC preview" in authority results with display from bug 29825 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Filed separately: Bug 36711 - Replace "MARC preview" in authority results with display from bug 29825 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org