http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|gmcharlt@gmail.com |robin@catalyst.net.nz Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 21866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21866&action=edit Bug 11013 - move hashing functions into their own module As the hashing functions were centralised into C4::Auth, this required more modules (C4::Members in particular) to use it. However, C4::Auth uses the database, and so anything that used C4::Members failed to load in the 00-load.t test. This patch moves the hashing into its own small module so this isn't an issue. Test plan: * Ensure that password related functions work: ** Creating a user account ** Logging in ** Changing a password (OPAC and staff client) ** LDAP logins still work like they should * Ensure that tests pass without a database server present Note: there are testing notes for LDAP on bug 9611 that'll bypass the need to set up an LDAP server. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Upgraded the importance, as packages can't be built while this bug is here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21867|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21873&action=edit [SIGNED-OFF] Bug 11013 - move hashing functions into their own module As the hashing functions were centralised into C4::Auth, this required more modules (C4::Members in particular) to use it. However, C4::Auth uses the database, and so anything that used C4::Members failed to load in the 00-load.t test. This patch moves the hashing into its own small module so this isn't an issue. Test plan: * Ensure that password related functions work: ** Creating a user account ** Logging in ** Changing a password (OPAC and staff client) ** LDAP logins still work like they should * Ensure that tests pass without a database server present Note: there are testing notes for LDAP on bug 9611 that'll bypass the need to set up an LDAP server. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All Works. No koha-qa errors Test 1) patch applied 2) new user created 3) change pass from opac/staff 4) change pass using LDAP (sort of, same as on Bug 9611) NOTE: Robin, you just sent an email about copyright headers, KohaPassword.pm's reads "...either version 2 of the License,...", coding guidelines suggests other wording and version 3 of GPL. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Bernardo Gonzalez Kriegel from comment #4)

NOTE: Robin, you just sent an email about copyright headers, KohaPassword.pm's reads "...either version 2 of the License,...", coding guidelines suggests other wording and version 3 of GPL.

That was a test! Actually, it was because I copy-pasted from elsewhere and didn't check. You are totally correct. I'll add a follow-up tomorrow. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21887|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21888&action=edit [SIGNED-OFF] Bug 11013 - make copyright headers current Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Updated copyright headers ok -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- In fact I think this report can be marked as resolved/duplicate. I let you change the status, except if you disagree. -- You are receiving this mail because: You are watching all bug changes.