http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39433&action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan ========= 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate <langcode> 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a "Languages" dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P5 - low -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #6 from Indranil Das Gupta <indradg@gmail.com> --- In reply to comment 4 and comment 5 Yes, what you say makes sense. Will be re-working the patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39444&action=edit Bug 14252: (followup) fix lang chooser for sublanguages This quick fix disables sublanguages dropdown, show all sublanguages on same level. To test: 1) Apply both patches 2) Translate to have sublanguages (en-NZ, de-DE, de-CH) 3) Go to opac, confirm you can select any lang/sublang 4) Check on movil device -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, followup fixes the display of sublanguages. First patch signed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39446|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39447&action=edit Bug 14252: (followup) fix lang chooser for sublanguages This quick fix disables sublanguages dropdown, show all sublanguages on same level. To test: 1) Apply both patches 2) Translate to have sublanguages (en-NZ, de-DE, de-CH) 3) Go to opac, confirm you can select any lang/sublang 4) Check on movil device 4th version. Removed rfc4646 subtag on sublanguages, think it's cleaner. Currently on master all translated languages/regions have valid description ('en' at least) Added language sort using rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39447|0 |1 is obsolete| | --- Comment #14 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39449&action=edit Bug 14252: (followup) fix lang chooser for sublanguages This quick fix disables sublanguages dropdown, show all sublanguages on same level. To test: 1) Apply both patches 2) Translate to have sublanguages (en-NZ, de-DE, de-CH) 3) Go to opac, confirm you can select any lang/sublang 4) Check on movil device 4th version. Removed rfc4646 subtag on sublanguages, think it's cleaner. Currently on master all translated languages/regions have valid description ('en' at least) Added language sort using rfc4646 subtag Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Followup fixes the issue with lang group dropdowns. Works well across standard desktop as well as mobile device with small screens (checked on 4.3" / 4.7" / 5") -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Indranil, Could you please sent an email on koha or koha-devel to get opinion on this new placement? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- I think it's not good idea to have the dropdown list for language switcher titled "Language". It's always going to be in the actual language and the user may not be able to recognize this as language switcher. If we want the dropdown, it's a bit better to call it by active language. But best approach is always to have links (or bottom bar, like in Koha) of available languages. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I understand Josef's point and agree. Currently the language names are clearly visible in their own language - with this patch they would get hidden in a menu labelled in a language I might not speak or understand. Example: If I don't know any Spanish, but end up on a Spanish website, I will look for a clear icon or better the terms 'english' or 'german' or 'Deutsch' to switch it. I won't recognize that the 'idiomas' menu is what I am looking for easily. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think flags are problematic in other ways, because picking one is not always easy for any language. Also - as long as it's a menu, that won't change the problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #24 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Katrin Fischer from comment #20)

I think I understand Josef's point and agree.

Currently the language names are clearly visible in their own language -

Unfortunately, everything is invisible right now, unless you know you have to scroll down to find the language names. It confused me more than once. And on mobile, I'd expect to find an option to switch languages in the header. I agree with the points of Josef (visible language names) and Katrin (no flags). We could hide the language names behind a universal "language switcher" symbol in the header, but there is none. Things I have seen used were a globe symbol, a flag symbol (unspecified), Fontawesome has this http://fontawesome.io/icon/language/ and there are probably more. Showing the language code of the language in use is also a way of doing things, but you need people to be able to read the script in use and recognize it as something representing a language. I found this to be an interesting read on the topic. http://flagsarenotlanguages.com/blog/2013/10/case-study-onefinestay-com-and-... Having thought about it a little more, I'd say moving the switcher is the wrong way to go. A switcher in the header should be an addition, not a replacement for the one in the footer. And the one in the footer should be visible without any scrolling, as it used to be, at least on a desktop size screen. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #26 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #22)

Hm, I think flags are problematic in other ways, because picking one is not always easy for any language. (...)

E.g. for Switzerland: We have German, French, Italian languages and it always looks a bit odd to see them symbolized by "foreign" flags (Germany, France, Italy)... (In reply to Mirko Tietgen from comment #24)

A switcher in the header should be an addition, not a replacement for the one in the footer. (...)

Why not having a syspref (Language selection in header or footer with footer as default)? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #28 from Indranil Das Gupta <indradg@gmail.com> --- Hi Marc (In reply to Marc Véron from comment #26)

(In reply to Katrin Fischer from comment #22)

...

Hm, I think flags are problematic in other ways, because picking one is not always easy for any language. (...)

E.g. for Switzerland: We have German, French, Italian languages and it always looks a bit odd to see them symbolized by "foreign" flags (Germany, France, Italy)...

The Swiss have 3, well think about India, 22 officially recognised languages, all well-represented in Unicode. :) As for the flag bit, IMHO the better way to go about it is to use the flag of the country the language is representing e.g. pt-PT should use Portugal's flag, whereas pt-BR should use Brazil's flag. That way all 3 languages of Switzerland should be tagged against the Swiss flag.

(In reply to Mirko Tietgen from comment #24)

...

A switcher in the header should be an addition, not a replacement for the one in the footer. (...)

Why not having a syspref (Language selection in header or footer with footer as default)?

+1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #30 from Marc Véron <veron@veron.ch> --- (In reply to Mirko Tietgen from comment #29)

(In reply to Marc Véron from comment #26)

...

Why not having a syspref (Language selection in header or footer with footer as default)?

Because I would like both. :P So a third option (»both«) would be nice.

Yes, indeed :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #32 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Oh... please disregard the note about scrolling past language chooser on every page of mobile device. That was me being to quick when looking at the screenshots :) But if I (now finally) understand the issue correctly we would indeed need a way to better communicate where you choose the language. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #34 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Gaetan Boisson from comment #33)

- I like the icon used by Indranil in his first suggestions (a very generic flag), i think a lot of people will associate a flag with a language selector on a website. There are other interesting options using language characters, but i have the feeling they need more space to be readable.

Yes, when I said flag, I didn't mean it had to be a country flag. A generic language selector icon of some sort (whether a flag, globe, etc.).

[SNIP] Choosing one flag over another will be a political choice...)

Hence, a generic icon of some sort. Flag shaped? Perhaps. Globe. Whatever, some graphic that screams, "Hey, this is where the language can be changed."

- I think we should keep links at the bottom, things at the bottom don't waste space, and some users will find them there.

Some users will not scroll below the current screen visual. :(

All in all i think we are very close to it: a language picker at the top, with a generic flag icon, sub-languages listed one after another, and links at the bottom where they used to be.

Generally, perhaps. Yes.

I am not even sure we need another syspref, if we have a css id for the top picker unhappy people will be able to hide it easily.

I always prefer a system preference option over a CSS option. The former requires less technical expertise. Someone playing around with Koha for evaluation purposes is not necessarily going to have CSS expertise or such available to them. Don't force librarians to learn HTML, CSS, Perl, Linux, etc. in order to use Koha. Let's keep the technical level required for customizations low if possible. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #36 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39650&action=edit (followup) correction of string comparison op the last followup commit had used '==' to compare the syspref string values - both, head and foot. corrects that to use 'eq' in both masthead.inc and opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39650|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 39650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39650 (followup) correction of string comparison op http://template-toolkit.org/docs/manual/Directives.html#section_IF_UNLESS_EL... Don't confuse Template Toolkit and Perl comparisons. It's easy to do. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #42 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39724&action=edit (Fixup) Fixes multiple issues in comment #40 Small fix - addresses the concerns pointed to by Mark Tompsett in comment #40 (code review) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #43 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39725&action=edit (Followup) Fixed issues pointed to in comment #40 Based on Mark's inputs in comment #40 - [1] selected 'mast' (short of 'masthead') and updated : (a) bug_14252-OpacLangSelectorMode_syspref.sql (b) sysprefs.sql (c) opac.pref [2] Reduced the calls to Koha.Preference() from : (a) masthead.inc (b) opac-bottom.inc After applying this patch, update the database once for it to pick up the new option values -'both|mast|foot'. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #44 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39726&action=edit (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #47 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to M. Tompsett from comment #46)

Comment on attachment 39725 [details] [review] (Followup) Fixed issues pointed to in comment #40

Review of attachment 39725 [details] [review]: ----------------------------------------------------------------- <snipped>

The default value should be 'foot'. New system preferences should not change current behaviours.

Mark, While I acknowledge the part that it shouldn't change current behavior, I do not agree with you on this. Earlier there was only 'foot', it is still retained by 'both', the masthead is an addition, not a replacement. The whole point of having the masthead switcher is nullified IMO if it is not available along with the earlier footer placement. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39443|0 |1 is obsolete| | --- Comment #49 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39728&action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan ========= 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate <langcode> 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a "Languages" dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Followup fix language chooser for sublanguages Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39707|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39730&action=edit (followup) Adds OpacLangSelectorMode syspref Based on discussion, this followup does the following: 1/ brings back the switcher on opac-bottom.inc 2/ adds a syspref OpacLangSelectorMode to toggle between the three modes: (a) show switcher both on masthead and footer (default) (b) footer only (b) masthead only Test plan ========= 1/ apply earlier patches attached to this bug in their correct order 2/ apply this followup patch 3/ run updatedatabase.pl to add in the atomic update 4/ goto admin/preferences.pl?tab=opac 5/ look up OpacLangSelectorMode, it should be set with default value "both masthead and footer" 6/ check OPAC to see if both locations show the selectors 7/ change OpacLangSelectorMode to 'only header' and 'only footer' at each iteration, and check if the selection has correctly toggled the selectors. It should Note: make sure you do not have the patch 11057 applied on the branch from before, otherwise merge conflict might happen. http://bugs.koha-community.org/show_bug.cgi?id=14252 Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39726|0 |1 is obsolete| | --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39732&action=edit (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. http://bugs.koha-community.org/show_bug.cgi?id=14252 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39733|0 |1 is obsolete| | --- Comment #55 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39734&action=edit Bug 14252: Follow up noprint and default values TEST PLAN --------- 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think maybe a compromise: new installations (sysprefs.sql) could be set to both, while we keep it for existing installations at 'foot'. Looking at this, and hoping not to be to nit-picky - why not use top|both|footer? Mast looks a bit weird and quite template specific. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #58 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Katrin Fischer from comment #56)

Hm, I think maybe a compromise: new installations (sysprefs.sql) could be set to both, while we keep it for existing installations at 'foot'.

Mark and I both agree with that! Nice suggestion!

Looking at this, and hoping not to be to nit-picky - why not use top|both|footer? Mast looks a bit weird and quite template specific.

^^^ Done! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39746|0 |1 is obsolete| | --- Comment #59 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39749&action=edit Bug 14252: (followup) addresses the QA Manager comments Addresses Katrin's comments in comment# 56 TEST PLAN --------- 1) Back up your DB 2) Ensure you have multiple languages, including some that have sub-languages (e.g. de-DE, de-CH) -- cd misc/translator -- perl translate install {language code} 3) Ensure that you have all the languages enabled -- Staff client -> Home -> Global system preferences --> I18N/L10N Check all the languages in opaclanguages. Ensure that opaclanguagesdisplay is 'Allow' 4) Open OPAC -- should only have languages in footer. Annoyingly below the fold. 5) Drop your koha database, and create a blank one. 6) Apply all patches 7) Reinstall all the known languages, so the templates are appropriately updated. 8) Go to staff client and do an install of koha, with all the dummy data. 9) Ensure you have all the languages enabled (see (3)) 10) Refresh your OPAC page -- language selector position should be in both the footer and at the top as expected. -- this confirms the sysprefs.sql change. 11) Restore your DB 12) run the updatedatabase.pl script 13) Ensure you have all the languages enabled (see (3)) 14) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 15) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 16) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 17) run koha qa test tools NOTE: Tested as a single batch together. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39728|0 |1 is obsolete| | Attachment #39729|0 |1 is obsolete| | Attachment #39730|0 |1 is obsolete| | Attachment #39731|0 |1 is obsolete| | Attachment #39732|0 |1 is obsolete| | Attachment #39734|0 |1 is obsolete| | Attachment #39749|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39857&action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan ========= 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate <langcode> 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a "Languages" dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Followup fix language chooser for sublanguages Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39859&action=edit Bug 14252: (followup) Adds OpacLangSelectorMode syspref Based on discussion, this followup does the following: 1/ brings back the switcher on opac-bottom.inc 2/ adds a syspref OpacLangSelectorMode to toggle between the three modes: (a) show switcher both on masthead and footer (default) (b) footer only (b) masthead only Test plan ========= 1/ apply earlier patches attached to this bug in their correct order 2/ apply this followup patch 3/ run updatedatabase.pl to add in the atomic update 4/ goto admin/preferences.pl?tab=opac 5/ look up OpacLangSelectorMode, it should be set with default value "both masthead and footer" 6/ check OPAC to see if both locations show the selectors 7/ change OpacLangSelectorMode to 'only header' and 'only footer' at each iteration, and check if the selection has correctly toggled the selectors. It should Note: make sure you do not have the patch 11057 applied on the branch from before, otherwise merge conflict might happen. http://bugs.koha-community.org/show_bug.cgi?id=14252 Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39861&action=edit Bug 14252: (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39863&action=edit Bug 14252: (followup) addresses the QA Manager comments Addresses Katrin's comments in comment# 56 TEST PLAN --------- 1) Back up your DB 2) Ensure you have multiple languages, including some that have sub-languages (e.g. de-DE, de-CH) -- cd misc/translator -- perl translate install {language code} 3) Ensure that you have all the languages enabled -- Staff client -> Home -> Global system preferences --> I18N/L10N Check all the languages in opaclanguages. Ensure that opaclanguagesdisplay is 'Allow' 4) Open OPAC -- should only have languages in footer. Annoyingly below the fold. 5) Drop your koha database, and create a blank one. 6) Apply all patches 7) Reinstall all the known languages, so the templates are appropriately updated. 8) Go to staff client and do an install of koha, with all the dummy data. 9) Ensure you have all the languages enabled (see (3)) 10) Refresh your OPAC page -- language selector position should be in both the footer and at the top as expected. -- this confirms the sysprefs.sql change. 11) Restore your DB 12) run the updatedatabase.pl script 13) Ensure you have all the languages enabled (see (3)) 14) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 15) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 16) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 17) run koha qa test tools NOTE: Tested as a single batch together. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12017 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12017 -- You are receiving this mail because: You are watching all bug changes.