[Bug 25842] New: Typo "streetype" in member-main-address-style.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Bug ID: 25842 Summary: Typo "streetype" in member-main-address-style.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: fridolin.somers@biblibre.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: fridolin.somers@biblibre.com, testopia@bugs.koha-community.org Depends on: 25070, 25839 There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. While not error-causing, they should be corrected for consistency. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 [Bug 25070] Include files to display address and contact must be refactored https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839 [Bug 25839] Typo patron.streetype in member-main-address-style.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #0)
While not error-causing, they should be corrected for consistency. Oh there is an error : field as mandatory in BorrowerMandatoryField does not work :(
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 106179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106179&action=edit Bug 25842: Fix typo streetype in member-main-address-style.inc There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory. See also : Bug 25839 - Typo patron.streetype in member-main-address-style.inc Test plan : 1) Add "streettype" in system preference "BorrowerMandatoryField" 2) Create a new patron 3) Without patch "Street type" field is not mandatory/required, with patch it is 4) Remove "streettype" from system preference "BorrowerMandatoryField" 5) Create a new patron 6) Check "Street type" field is not mandatory/required 7) Select a value and save 8) Edit again patron 9) Check value is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106179|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 106181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106181&action=edit Bug 25842: Fix typo streetype in member-main-address-style.inc There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory. See also : Bug 25839 - Typo patron.streetype in member-main-address-style.inc Test plan : 1) Add "streettype" in system preference "BorrowerMandatoryField" 2) Create a new patron 3) Without patch "Street type" field is not mandatory/required, with patch it is 4) Remove "streettype" from system preference "BorrowerMandatoryField" 5) Create a new patron 6) Check "Street type" field is not mandatory/required 7) Select a value and save 8) Edit again patron 9) Check value is selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Needed for 20.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00 20.05.01 released in| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org